Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 194703008: Fix lazy deopt after tagged binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/lithium-codegen-a64.h ('k') | src/arm/lithium-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 osr_pc_offset_ = masm()->pc_offset(); 764 osr_pc_offset_ = masm()->pc_offset();
765 765
766 // Adjust the frame size, subsuming the unoptimized frame into the 766 // Adjust the frame size, subsuming the unoptimized frame into the
767 // optimized frame. 767 // optimized frame.
768 int slots = GetStackSlotCount() - graph()->osr()->UnoptimizedFrameSlots(); 768 int slots = GetStackSlotCount() - graph()->osr()->UnoptimizedFrameSlots();
769 ASSERT(slots >= 0); 769 ASSERT(slots >= 0);
770 __ Claim(slots); 770 __ Claim(slots);
771 } 771 }
772 772
773 773
774 void LCodeGen::GenerateBodyInstructionPre(LInstruction* instr) {
775 if (!instr->IsLazyBailout() && !instr->IsGap()) {
776 safepoints_.BumpLastLazySafepointIndex();
777 }
778 }
779
780
774 bool LCodeGen::GenerateDeferredCode() { 781 bool LCodeGen::GenerateDeferredCode() {
775 ASSERT(is_generating()); 782 ASSERT(is_generating());
776 if (deferred_.length() > 0) { 783 if (deferred_.length() > 0) {
777 for (int i = 0; !is_aborted() && (i < deferred_.length()); i++) { 784 for (int i = 0; !is_aborted() && (i < deferred_.length()); i++) {
778 LDeferredCode* code = deferred_[i]; 785 LDeferredCode* code = deferred_[i];
779 786
780 HValue* value = 787 HValue* value =
781 instructions_->at(code->instruction_index())->hydrogen_value(); 788 instructions_->at(code->instruction_index())->hydrogen_value();
782 RecordAndWritePosition( 789 RecordAndWritePosition(
783 chunk()->graph()->SourcePositionToScriptPosition(value->position())); 790 chunk()->graph()->SourcePositionToScriptPosition(value->position()));
(...skipping 5046 matching lines...) Expand 10 before | Expand all | Expand 10 after
5830 __ Bind(&out_of_object); 5837 __ Bind(&out_of_object);
5831 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5838 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5832 // Index is equal to negated out of object property index plus 1. 5839 // Index is equal to negated out of object property index plus 1.
5833 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5840 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5834 __ Ldr(result, FieldMemOperand(result, 5841 __ Ldr(result, FieldMemOperand(result,
5835 FixedArray::kHeaderSize - kPointerSize)); 5842 FixedArray::kHeaderSize - kPointerSize));
5836 __ Bind(&done); 5843 __ Bind(&done);
5837 } 5844 }
5838 5845
5839 } } // namespace v8::internal 5846 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/lithium-codegen-a64.h ('k') | src/arm/lithium-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698