Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 194703008: Fix lazy deopt after tagged binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2442 matching lines...) Expand 10 before | Expand all | Expand 10 after
2453 stream->Add(" push "); 2453 stream->Add(" push ");
2454 } 2454 }
2455 values_[i]->PrintNameTo(stream); 2455 values_[i]->PrintNameTo(stream);
2456 if (i > 0) stream->Add(","); 2456 if (i > 0) stream->Add(",");
2457 } 2457 }
2458 } 2458 }
2459 } 2459 }
2460 2460
2461 2461
2462 void HSimulate::ReplayEnvironment(HEnvironment* env) { 2462 void HSimulate::ReplayEnvironment(HEnvironment* env) {
2463 if (done_with_replay_) return;
2463 ASSERT(env != NULL); 2464 ASSERT(env != NULL);
2464 env->set_ast_id(ast_id()); 2465 env->set_ast_id(ast_id());
2465 env->Drop(pop_count()); 2466 env->Drop(pop_count());
2466 for (int i = values()->length() - 1; i >= 0; --i) { 2467 for (int i = values()->length() - 1; i >= 0; --i) {
2467 HValue* value = values()->at(i); 2468 HValue* value = values()->at(i);
2468 if (HasAssignedIndexAt(i)) { 2469 if (HasAssignedIndexAt(i)) {
2469 env->Bind(GetAssignedIndexAt(i), value); 2470 env->Bind(GetAssignedIndexAt(i), value);
2470 } else { 2471 } else {
2471 env->Push(value); 2472 env->Push(value);
2472 } 2473 }
2473 } 2474 }
2475 done_with_replay_ = true;
2474 } 2476 }
2475 2477
2476 2478
2477 static void ReplayEnvironmentNested(const ZoneList<HValue*>* values, 2479 static void ReplayEnvironmentNested(const ZoneList<HValue*>* values,
2478 HCapturedObject* other) { 2480 HCapturedObject* other) {
2479 for (int i = 0; i < values->length(); ++i) { 2481 for (int i = 0; i < values->length(); ++i) {
2480 HValue* value = values->at(i); 2482 HValue* value = values->at(i);
2481 if (value->IsCapturedObject()) { 2483 if (value->IsCapturedObject()) {
2482 if (HCapturedObject::cast(value)->capture_id() == other->capture_id()) { 2484 if (HCapturedObject::cast(value)->capture_id() == other->capture_id()) {
2483 values->at(i) = other; 2485 values->at(i) = other;
(...skipping 2059 matching lines...) Expand 10 before | Expand all | Expand 10 after
4543 break; 4545 break;
4544 case kExternalMemory: 4546 case kExternalMemory:
4545 stream->Add("[external-memory]"); 4547 stream->Add("[external-memory]");
4546 break; 4548 break;
4547 } 4549 }
4548 4550
4549 stream->Add("@%d", offset()); 4551 stream->Add("@%d", offset());
4550 } 4552 }
4551 4553
4552 } } // namespace v8::internal 4554 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698