Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/heap.cc

Issue 194703008: Fix lazy deopt after tagged binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/deoptimizer.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 607
608 AllowHeapAllocation for_the_rest_of_the_epilogue; 608 AllowHeapAllocation for_the_rest_of_the_epilogue;
609 609
610 #ifdef DEBUG 610 #ifdef DEBUG
611 if (FLAG_print_global_handles) isolate_->global_handles()->Print(); 611 if (FLAG_print_global_handles) isolate_->global_handles()->Print();
612 if (FLAG_print_handles) PrintHandles(); 612 if (FLAG_print_handles) PrintHandles();
613 if (FLAG_gc_verbose) Print(); 613 if (FLAG_gc_verbose) Print();
614 if (FLAG_code_stats) ReportCodeStatistics("After GC"); 614 if (FLAG_code_stats) ReportCodeStatistics("After GC");
615 #endif 615 #endif
616 if (FLAG_deopt_every_n_garbage_collections > 0) { 616 if (FLAG_deopt_every_n_garbage_collections > 0) {
617 // TODO(jkummerow/ulan/jarin): This is not safe! We can't assume that
618 // the topmost optimized frame can be deoptimized safely, because it
619 // might not have a lazy bailout point right after its current PC.
617 if (++gcs_since_last_deopt_ == FLAG_deopt_every_n_garbage_collections) { 620 if (++gcs_since_last_deopt_ == FLAG_deopt_every_n_garbage_collections) {
618 Deoptimizer::DeoptimizeAll(isolate()); 621 Deoptimizer::DeoptimizeAll(isolate());
619 gcs_since_last_deopt_ = 0; 622 gcs_since_last_deopt_ = 0;
620 } 623 }
621 } 624 }
622 625
623 UpdateMaximumCommitted(); 626 UpdateMaximumCommitted();
624 627
625 isolate_->counters()->alive_after_last_gc()->Set( 628 isolate_->counters()->alive_after_last_gc()->Set(
626 static_cast<int>(SizeOfObjects())); 629 static_cast<int>(SizeOfObjects()));
(...skipping 7085 matching lines...) Expand 10 before | Expand all | Expand 10 after
7712 static_cast<int>(object_sizes_last_time_[index])); 7715 static_cast<int>(object_sizes_last_time_[index]));
7713 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT) 7716 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT)
7714 #undef ADJUST_LAST_TIME_OBJECT_COUNT 7717 #undef ADJUST_LAST_TIME_OBJECT_COUNT
7715 7718
7716 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_)); 7719 OS::MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_));
7717 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_)); 7720 OS::MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_));
7718 ClearObjectStats(); 7721 ClearObjectStats();
7719 } 7722 }
7720 7723
7721 } } // namespace v8::internal 7724 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/deoptimizer.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698