bluetooth: Return int8_t and use -128 for unknown tx power.

bluetooth: Return int8_t and use -128 for unknown tx power.

According to the spec -128 should be used for an invalid Tx Power so this
patch adds a new constant for that value and returns it if the platform
doesn't provide a Tx Power.

TxPower and RSSI should both be int8 but because DBus doesn't support
int8 the platform independent functions returned int16. This patch
changes GetInquiryTxPower and GetInquiryRSSI to return a int8.

BUG=551572

[ortuno, 2016-05-02 19:17:49]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 19:18:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/20001

[commit-bot: I haz the power, 2016-05-02 19:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 19:36:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-05-02 19:59:23]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 19:59:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/40001

[commit-bot: I haz the power, 2016-05-02 20:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 20:12:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ortuno, 2016-05-02 20:29:34]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 20:29:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/60001

[commit-bot: I haz the power, 2016-05-02 20:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 20:44:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[ortuno, 2016-05-03 17:55:38]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 17:56:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/80001

[commit-bot: I haz the power, 2016-05-03 17:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 17:59:31]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-05-03 18:15:35]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 18:16:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/100001

[commit-bot: I haz the power, 2016-05-03 18:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 18:31:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2016-05-03 19:38:17]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 19:38:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/120001

[ortuno, 2016-05-03 19:58:12]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 19:58:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/140001

[ortuno, 2016-05-03 20:34:55]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-05-03 20:34:57]

scheib: PTAL at content/ device/ and third_party/WebKit

[commit-bot: I haz the power, 2016-05-03 23:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 23:05:25]

Dry run: This issue passed the CQ dry run.

[scheib, 2016-05-04 01:18:38]

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device.h:80: // The value returned if the RSSI cannot
be read.
Helps to cite the location of the Bluetooth spec these come from.

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
File device/bluetooth/bluez/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2510: // RSSI should be a
int8 but luez returns a int16 because DBus doesn't
bluez
^

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2542:
EXPECT_TRUE(devices[idx]->GetInquiryRSSI() == BluetoothDevice::kUnknownRSSI);
EXPECT_EQ instead of _TRUE. (and elsewhere)

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2610: // Large valid value.
(127 is used for BluetoothDevice::kUnknownTxPower).
What does Bluez use for UnknownTxPower? This patch is changing chromium to use
-128. This comment, and previous block need updates?

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/dbus/...
File device/bluetooth/dbus/bluetooth_device_client.cc (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/dbus/...
device/bluetooth/dbus/bluetooth_device_client.cc:22: constexpr int8_t
kUnknownRSSI = 127;
Let's use the constants from bluetootn_device.h

https://codereview.chromium.org/1941923002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp
(right):

https://codereview.chromium.org/1941923002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp:10:
const int8_t kUnknownRSSI = 127;
Comment explaining the source of the numbers (cite spec as in
bluetooth_device.h)

[ortuno, 2016-05-04 16:44:12]

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device.h:80: // The value returned if the RSSI cannot
be read.
On 2016/05/04 at 01:18:37, scheib wrote:
> Helps to cite the location of the Bluetooth spec these come from.

Done. Let me know if you prefer another format.

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
File device/bluetooth/bluez/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2510: // RSSI should be a
int8 but luez returns a int16 because DBus doesn't
On 2016/05/04 at 01:18:37, scheib wrote:
> bluez
> ^

Done.

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2542:
EXPECT_TRUE(devices[idx]->GetInquiryRSSI() == BluetoothDevice::kUnknownRSSI);
On 2016/05/04 at 01:18:37, scheib wrote:
> EXPECT_EQ instead of _TRUE. (and elsewhere)

That's what I tried to do the first time but I get a linking error :/

error: undefined reference to 'device::BluetoothDevice::kUnknownRSSI'

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:2610: // Large valid value.
(127 is used for BluetoothDevice::kUnknownTxPower).
On 2016/05/04 at 01:18:37, scheib wrote:
> What does Bluez use for UnknownTxPower?

In bluez, if a property is not present property.is_valid() returns false.

> This patch is changing chromium to use -128. This comment, and previous block
need updates?

Done.

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/dbus/...
File device/bluetooth/dbus/bluetooth_device_client.cc (right):

https://codereview.chromium.org/1941923002/diff/140001/device/bluetooth/dbus/...
device/bluetooth/dbus/bluetooth_device_client.cc:22: constexpr int8_t
kUnknownRSSI = 127;
On 2016/05/04 at 01:18:38, scheib wrote:
> Let's use the constants from bluetootn_device.h

I don't think we are allowed to depend on device/bluetooth/ classes.

https://codereview.chromium.org/1941923002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp
(right):

https://codereview.chromium.org/1941923002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp:10:
const int8_t kUnknownRSSI = 127;
On 2016/05/04 at 01:18:38, scheib wrote:
> Comment explaining the source of the numbers (cite spec as in
bluetooth_device.h)

We removed BluetoothAdvertisingData so no need to repeat the value here.

[ortuno, 2016-05-04 16:44:16]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 16:44:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/200001

[commit-bot: I haz the power, 2016-05-04 17:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:29:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-05-04 18:41:53]

Patchset #12 (id:220001) has been deleted

[ortuno, 2016-05-04 18:43:30]

Changed to EXPECT_EQ

[ortuno, 2016-05-04 20:04:47]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 20:05:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/240001

[commit-bot: I haz the power, 2016-05-04 21:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:48:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-05-04 22:55:24]

LGTM

[ortuno, 2016-05-04 22:56:19]

ortuno@chromium.org changed reviewers:
+ isherman@chromium.org

[ortuno, 2016-05-04 22:56:20]

isherman: PTAL at components/

[Ilya Sherman, 2016-05-04 23:01:44]

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
File components/proximity_auth/proximity_monitor_impl_unittest.cc (right):

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:534:
monitor_.Start();
nit: I'd keep this line right above ProvideConnectionInfo

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:596:
BluetoothDevice::kUnknownRSSI, 1);
Hmm, the reported RSSI shouldn't change, even if the backing constant happens to
have changed.  This test expectation should remain the concrete number 127.

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:599:
BluetoothDevice::kUnknownTxPower, 1);
Ditto.

[ortuno, 2016-05-06 22:20:35]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 22:21:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/280001

[commit-bot: I haz the power, 2016-05-06 22:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 22:35:14]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[ortuno, 2016-05-06 23:17:29]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 23:18:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/300001

[commit-bot: I haz the power, 2016-05-06 23:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 23:31:55]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-05-06 23:57:58]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 23:58:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/340001

[ortuno, 2016-05-07 00:32:09]

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
File components/proximity_auth/proximity_monitor_impl_unittest.cc (right):

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:534:
monitor_.Start();
On 2016/05/04 at 23:01:44, Ilya Sherman (Away May 5-15) wrote:
> nit: I'd keep this line right above ProvideConnectionInfo

Done.

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:596:
BluetoothDevice::kUnknownRSSI, 1);
On 2016/05/04 at 23:01:44, Ilya Sherman (Away May 5-15) wrote:
> Hmm, the reported RSSI shouldn't change, even if the backing constant happens
to have changed.  This test expectation should remain the concrete number 127.

Ah. I misunderstood the purpose of the test. Fixed.

https://codereview.chromium.org/1941923002/diff/240001/components/proximity_a...
components/proximity_auth/proximity_monitor_impl_unittest.cc:599:
BluetoothDevice::kUnknownTxPower, 1);
On 2016/05/04 at 23:01:44, Ilya Sherman (Away May 5-15) wrote:
> Ditto.

Done.

[ortuno, 2016-05-07 00:34:32]

scheib: PTAL again at device/bluetooth
isherman: PTAL at components/proximity_auth
lhchavez: PTAL at components/arc
tengs: PTAL at chrome/b/e/a/easy_unlock_private
stevenjb: PTAL at extensions/b/a/bluetooth

[commit-bot: I haz the power, 2016-05-07 00:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 00:34:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2016-05-07 00:35:36]

ortuno@chromium.org changed reviewers:
+ lhchavez@chromium.org, stevenjb@chromium.org, tengs@chromium.org

[ortuno, 2016-05-07 00:35:37]

scheib: PTAL again at device/bluetooth
isherman: PTAL at components/proximity_auth
lhchavez: PTAL at components/arc
tengs: PTAL at chrome/b/e/a/easy_unlock_private
stevenjb: PTAL at extensions/b/a/bluetooth

[ortuno, 2016-05-07 00:52:50]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-07 00:53:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941923002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941923002/360001

[commit-bot: I haz the power, 2016-05-07 02:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 02:04:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scheib, 2016-05-07 02:06:52]

https://codereview.chromium.org/1941923002/diff/360001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_classic_device_mac.mm (right):

https://codereview.chromium.org/1941923002/diff/360001/device/bluetooth/bluet...
device/bluetooth/bluetooth_classic_device_mac.mm:149: return
base::Optional<int8_t>();
return nullopt;

https://codereview.chromium.org/1941923002/diff/360001/device/bluetooth/bluet...
device/bluetooth/bluetooth_classic_device_mac.mm:185: connection_info.rssi =
base::make_optional(rssi);
In the event rssi is 127 we want to use nullopt, else make_optional(rssi); I
think:
  connection_info.rssi = (rssi == 127) ? base::nullopt :
base::make_optional(rssi);

[Luis Héctor Chávez, 2016-05-07 03:31:45]

lhchavez@chromium.org changed reviewers:
+ smbarber@chromium.org

[Luis Héctor Chávez, 2016-05-07 03:31:46]

smbarber PTAL components/arc/bluetooth

[Steve Barber, 2016-05-07 04:12:20]

On 2016/05/07 03:31:46, Luis Héctor Chávez wrote:
> smbarber PTAL components/arc/bluetooth

components/arc/bluetooth LGTM

[Luis Héctor Chávez, 2016-05-07 04:13:21]

lgtm

[stevenjb, 2016-05-09 17:19:51]

bluetooth_api_utils.cc lgtm

[Tim Song, 2016-05-09 17:32:00]

lgtm