components/arc/bluetooth/arc_bluetooth_bridge.cc - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/bluetooth/arc_bluetooth_bridge.cc

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Fix extensions tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc ('k') | components/proximity_auth/proximity_monitor_impl.cc » ('j') | device/bluetooth/bluetooth_classic_device_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/arc/bluetooth/arc_bluetooth_bridge.cc

diff --git a/components/arc/bluetooth/arc_bluetooth_bridge.cc b/components/arc/bluetooth/arc_bluetooth_bridge.cc

index f34a400da1107943fc4ce5f38ec56d737d1c3d08..8877c9f922f1760a3e07b92c47f03462d5604dfd 100644

--- a/components/arc/bluetooth/arc_bluetooth_bridge.cc

+++ b/components/arc/bluetooth/arc_bluetooth_bridge.cc

@@ -573,9 +573,11 @@ ArcBluetoothBridge::GetDeviceProperties(mojom::BluetoothPropertyType type,

}

if (type == mojom::BluetoothPropertyType::ALL ||

type == mojom::BluetoothPropertyType::REMOTE_RSSI) {

- mojom::BluetoothPropertyPtr btp = mojom::BluetoothProperty::New();

- btp->set_remote_rssi(device->GetInquiryRSSI());

- properties.push_back(std::move(btp));

+ if (device->GetInquiryRSSI()) {

+ mojom::BluetoothPropertyPtr btp = mojom::BluetoothProperty::New();

+ btp->set_remote_rssi(device->GetInquiryRSSI().value());

+ properties.push_back(std::move(btp));

+ }

}

// TODO(smbarber): Add remote version info