Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1945823003: bluetooth: Remove BluetoothAdvertisementData (Closed)

Created:
4 years, 7 months ago by ortuno
Modified:
4 years, 7 months ago
Reviewers:
palmer, Jeffrey Yasskin
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, haraken, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove BluetoothAdvertisementData The spec is changing the way in which users can receive advertisement data: https://github.com/WebBluetoothCG/web-bluetooth/pull/235 BUG=568137 Committed: https://crrev.com/0fe4ab8f3553ebfe57f22e7abfd853fe23858f0b Cr-Commit-Position: refs/heads/master@{#392222}

Patch Set 1 #

Patch Set 2 : Remove fake adapters #

Total comments: 2

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -362 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/bluetooth/bluetooth_device.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/common/bluetooth/bluetooth_device.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/common/bluetooth/bluetooth_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/bluetooth/bluetooth_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 3 chunks +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/advertising-data.html View 1 chunk +0 lines, -118 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h View 2 chunks +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (10 generated)
ortuno
jyasskin: PTAL
4 years, 7 months ago (2016-05-04 15:56:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945823003/20001
4 years, 7 months ago (2016-05-04 16:27:44 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/216211)
4 years, 7 months ago (2016-05-04 17:46:00 UTC) #7
Jeffrey Yasskin
LGTM with the web-exposed test fixed. https://codereview.chromium.org/1945823003/diff/20001/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl File third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl (left): https://codereview.chromium.org/1945823003/diff/20001/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl#oldcode11 third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl:11: ] interface BluetoothAdvertisingData ...
4 years, 7 months ago (2016-05-04 18:16:17 UTC) #8
ortuno
Thanks! Test fixed. https://codereview.chromium.org/1945823003/diff/20001/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl File third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl (left): https://codereview.chromium.org/1945823003/diff/20001/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl#oldcode11 third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl:11: ] interface BluetoothAdvertisingData { On 2016/05/04 ...
4 years, 7 months ago (2016-05-04 20:22:24 UTC) #9
ortuno
palmer: PTAL at bluetooth_messages.h
4 years, 7 months ago (2016-05-04 20:23:01 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945823003/40001
4 years, 7 months ago (2016-05-04 21:11:20 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 23:07:25 UTC) #15
palmer
lgtm
4 years, 7 months ago (2016-05-06 21:28:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945823003/40001
4 years, 7 months ago (2016-05-06 21:31:33 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-07 00:47:46 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 00:48:52 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fe4ab8f3553ebfe57f22e7abfd853fe23858f0b
Cr-Commit-Position: refs/heads/master@{#392222}

Powered by Google App Engine
This is Rietveld 408576698