device/bluetooth/bluetooth_classic_device_mac.h - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_classic_device_mac.h

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Fix extensions tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/proximity_monitor_impl_unittest.cc ('k') | device/bluetooth/bluetooth_classic_device_mac.mm » ('j') | device/bluetooth/bluetooth_classic_device_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_classic_device_mac.h

diff --git a/device/bluetooth/bluetooth_classic_device_mac.h b/device/bluetooth/bluetooth_classic_device_mac.h

index acd1dca315e7a0a2d6128b5129293fd986a6e905..6a0e59242d017b35b99ba74a6d9d92d1f21e49cd 100644

--- a/device/bluetooth/bluetooth_classic_device_mac.h

+++ b/device/bluetooth/bluetooth_classic_device_mac.h

@@ -41,8 +41,8 @@ class BluetoothClassicDeviceMac : public BluetoothDeviceMac {

bool IsConnectable() const override;

bool IsConnecting() const override;

UUIDList GetUUIDs() const override;

- int16_t GetInquiryRSSI() const override;

- int16_t GetInquiryTxPower() const override;

+ base::Optional<int8_t> GetInquiryRSSI() const override;

+ base::Optional<int8_t> GetInquiryTxPower() const override;

bool ExpectingPinCode() const override;

bool ExpectingPasskey() const override;

bool ExpectingConfirmation() const override;

@@ -89,7 +89,7 @@ class BluetoothClassicDeviceMac : public BluetoothDeviceMac {

// Implementation to read the host's transmit power level of type

// |power_level_type|.

- int GetHostTransmitPower(

+ base::Optional<int8_t> GetHostTransmitPower(

BluetoothHCITransmitPowerLevelType power_level_type) const;

base::scoped_nsobject<IOBluetoothDevice> device_;