device/bluetooth/dbus/bluetooth_device_client.h - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_device_client.h

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Fix extensions tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_classic_device_mac.mm ('K') | « device/bluetooth/bluez/bluetooth_device_bluez.cc ('k') | device/bluetooth/dbus/bluetooth_device_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_device_client.h

diff --git a/device/bluetooth/dbus/bluetooth_device_client.h b/device/bluetooth/dbus/bluetooth_device_client.h

index 676b44a86bb06f8b63988d2c5cad62d3e64c15f4..c157d379f406f8ca4f462f2812109216f0d3a125 100644

--- a/device/bluetooth/dbus/bluetooth_device_client.h

+++ b/device/bluetooth/dbus/bluetooth_device_client.h

@@ -13,6 +13,7 @@

#include "base/callback.h"

#include "base/macros.h"

#include "base/observer_list.h"

+#include "base/optional.h"

#include "base/values.h"

#include "dbus/object_path.h"

#include "dbus/property.h"

@@ -185,9 +186,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceClient : public BluezDBusClient {

// The callback invoked for a successful GetConnInfo API call with the

// RSSI, TX power, and maximum TX power of the current connection.

- typedef base::Callback<void(int16_t rssi,

- int16_t transmit_power,

- int16_t max_transmit_power)> ConnInfoCallback;

+ typedef base::Callback<void(

+ const base::Optional<int16_t>& rssi,

+ const base::Optional<int16_t>& transmit_power,

+ const base::Optional<int16_t>& max_transmit_power)>

+ ConnInfoCallback;

// Returns the RSSI, TX power, and maximum TX power of a connection to the

// device with object path |object_path|. If the device is not connected, then