device/bluetooth/bluetooth_low_energy_device_mac.mm - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_low_energy_device_mac.mm

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Fix extensions tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_classic_device_mac.mm ('K') | « device/bluetooth/bluetooth_low_energy_device_mac.h ('k') | device/bluetooth/bluez/bluetooth_bluez_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_low_energy_device_mac.mm

diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.mm b/device/bluetooth/bluetooth_low_energy_device_mac.mm

index c3d6d1d154dfc5bb6ec9ab61995de7ffc31f34e6..ce4f7f3f351777f9ce07899c4a4fa0633e76fe00 100644

--- a/device/bluetooth/bluetooth_low_energy_device_mac.mm

+++ b/device/bluetooth/bluetooth_low_energy_device_mac.mm

@@ -145,13 +145,13 @@ BluetoothDevice::UUIDList BluetoothLowEnergyDeviceMac::GetUUIDs() const {

advertised_uuids_.end());

}

-int16_t BluetoothLowEnergyDeviceMac::GetInquiryRSSI() const {

- return kUnknownPower;

+base::Optional<int8_t> BluetoothLowEnergyDeviceMac::GetInquiryRSSI() const {

+ return base::Optional<int8_t>();

}

-int16_t BluetoothLowEnergyDeviceMac::GetInquiryTxPower() const {

+base::Optional<int8_t> BluetoothLowEnergyDeviceMac::GetInquiryTxPower() const {

NOTIMPLEMENTED();

- return kUnknownPower;

+ return base::Optional<int8_t>();

}

bool BluetoothLowEnergyDeviceMac::ExpectingPinCode() const {