Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Improve performance of InstrumentingAgents. This patch moves from set of InstrumentingAgents to multiple per-agent sets of instrumenting agents. This should speed up instrumentation in case only some of the agents are enabled. BUG=606247 Committed: https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63 Cr-Commit-Position: refs/heads/master@{#390526}

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed extra file #

Patch Set 3 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -203 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 8 chunks +42 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectedFrames.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 6 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 4 chunks +61 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InstrumentingSessions.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 6 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 5 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-04-28 19:06:42 UTC) #2
caseq
lgtm https://codereview.chromium.org/1924173002/diff/1/third_party/WebKit/Source/core/inspector/InstrumentingAgents.h File third_party/WebKit/Source/core/inspector/InstrumentingAgents.h (right): https://codereview.chromium.org/1924173002/diff/1/third_party/WebKit/Source/core/inspector/InstrumentingAgents.h#newcode1 third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1: #include "core/InstrumentingAgentsInl.h" nit: let's include directly?
4 years, 7 months ago (2016-04-28 19:22:57 UTC) #3
dgozman
https://codereview.chromium.org/1924173002/diff/1/third_party/WebKit/Source/core/inspector/InstrumentingAgents.h File third_party/WebKit/Source/core/inspector/InstrumentingAgents.h (right): https://codereview.chromium.org/1924173002/diff/1/third_party/WebKit/Source/core/inspector/InstrumentingAgents.h#newcode1 third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1: #include "core/InstrumentingAgentsInl.h" On 2016/04/28 19:22:57, caseq wrote: > nit: ...
4 years, 7 months ago (2016-04-28 19:45:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924173002/20001
4 years, 7 months ago (2016-04-28 19:46:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/58338)
4 years, 7 months ago (2016-04-28 20:05:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924173002/40001
4 years, 7 months ago (2016-04-28 21:05:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 22:57:45 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:31 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4e025c3657c27292c63486b00c163ae63e25e63
Cr-Commit-Position: refs/heads/master@{#390526}

Powered by Google App Engine
This is Rietveld 408576698