third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp - Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorSession.cpp ('k') | third_party/WebKit/Source/core/inspector/InstrumentingSessions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

index d56155896be92c392e83c7df8543aae948e8e3a1..3bd8ca0708a01c7a228b8a03f442451d47c2b63b 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp

@@ -65,7 +65,7 @@ void InspectorWorkerAgent::restore()

{

if (!enabled())

return;

- m_instrumentingAgents->setInspectorWorkerAgent(this);

+ m_instrumentingAgents->addInspectorWorkerAgent(this);

connectToAllProxies();

}

@@ -74,7 +74,7 @@ void InspectorWorkerAgent::enable(ErrorString*)

if (enabled())

return;

m_state->setBoolean(WorkerAgentState::workerInspectionEnabled, true);

- m_instrumentingAgents->setInspectorWorkerAgent(this);

+ m_instrumentingAgents->addInspectorWorkerAgent(this);

connectToAllProxies();

}

@@ -84,7 +84,7 @@ void InspectorWorkerAgent::disable(ErrorString*)

return;

m_state->setBoolean(WorkerAgentState::workerInspectionEnabled, false);

m_state->setBoolean(WorkerAgentState::waitForDebuggerOnStart, false);

- m_instrumentingAgents->setInspectorWorkerAgent(nullptr);

+ m_instrumentingAgents->removeInspectorWorkerAgent(this);

for (auto& idProxy : m_connectedProxies)

idProxy.value->disconnectFromInspector(this);

m_connectedProxies.clear();