third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp - Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

index b41cbcfe4177f5d71c89a2a80bd5d40ad41bd88a..6f8080da82b2addb719b100abbea711adad4b861 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

@@ -683,7 +683,7 @@ void InspectorCSSAgent::wasEnabled()

return;

}

- m_instrumentingAgents->setInspectorCSSAgent(this);

+ m_instrumentingAgents->addInspectorCSSAgent(this);

m_domAgent->setDOMListener(this);

HeapVector<Member<Document>> documents = m_domAgent->documents();

for (Document* document : documents)

@@ -694,7 +694,7 @@ void InspectorCSSAgent::disable(ErrorString*)

{

reset();

m_domAgent->setDOMListener(nullptr);

- m_instrumentingAgents->setInspectorCSSAgent(0);

+ m_instrumentingAgents->removeInspectorCSSAgent(this);

m_state->setBoolean(CSSAgentState::cssAgentEnabled, false);

m_resourceContentLoader->cancel(m_resourceContentLoaderClientId);

}