third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index cc598311e7bb87e65f0dec7aa46912b3eadd8cee..d93d99411e883ea9bcdf87f4d4080a26618a3491 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -149,7 +149,7 @@ void InspectorDOMDebuggerAgent::disable(ErrorString*)

void InspectorDOMDebuggerAgent::restore()

{

if (m_state->booleanProperty(DOMDebuggerAgentState::enabled, false))

- m_instrumentingAgents->setInspectorDOMDebuggerAgent(this);

+ m_instrumentingAgents->addInspectorDOMDebuggerAgent(this);

}

void InspectorDOMDebuggerAgent::setEventListenerBreakpoint(ErrorString* error, const String& eventName, const Maybe<String>& targetName)

@@ -626,11 +626,11 @@ void InspectorDOMDebuggerAgent::didRemoveBreakpoint()

void InspectorDOMDebuggerAgent::setEnabled(bool enabled)

{

if (enabled) {

- m_instrumentingAgents->setInspectorDOMDebuggerAgent(this);

+ m_instrumentingAgents->addInspectorDOMDebuggerAgent(this);

m_state->setBoolean(DOMDebuggerAgentState::enabled, true);

} else {

m_state->remove(DOMDebuggerAgentState::enabled);

- m_instrumentingAgents->setInspectorDOMDebuggerAgent(nullptr);

+ m_instrumentingAgents->removeInspectorDOMDebuggerAgent(this);

}