third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index 8812e24dbe49b2fd8b5ad52c34b0949eb5a040fb..9c2e7cc2bb33e9583d90af38d1c4b45eabae1b7c 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -483,7 +483,7 @@ void InspectorDOMAgent::innerEnable()

m_history = new InspectorHistory();

m_domEditor = new DOMEditor(m_history.get());

m_document = m_inspectedFrames->root()->document();

- m_instrumentingAgents->setInspectorDOMAgent(this);

+ m_instrumentingAgents->addInspectorDOMAgent(this);

if (m_backendNodeIdToInspect)

frontend()->inspectNodeRequested(m_backendNodeIdToInspect);

m_backendNodeIdToInspect = 0;

@@ -510,7 +510,7 @@ void InspectorDOMAgent::disable(ErrorString* errorString)

}

m_state->setBoolean(DOMAgentState::domAgentEnabled, false);

setSearchingForNode(errorString, NotSearching, Maybe<protocol::DOM::HighlightConfig>());

- m_instrumentingAgents->setInspectorDOMAgent(nullptr);

+ m_instrumentingAgents->removeInspectorDOMAgent(this);

m_history.clear();

m_domEditor.clear();

setDocument(nullptr);