third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 1924173002: [DevTools] Improve performance of InstrumentingAgents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectedFrames.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index 6a3ecbd6c720d41edb6b26d1ea07311d490207f1..355b2499ebe00c4edf5935411653310cb8c492ac 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -60,7 +60,7 @@ void InspectorAnimationAgent::restore()

void InspectorAnimationAgent::enable(ErrorString*)

{

m_state->setBoolean(AnimationAgentState::animationAgentEnabled, true);

- m_instrumentingAgents->setInspectorAnimationAgent(this);

+ m_instrumentingAgents->addInspectorAnimationAgent(this);

}

void InspectorAnimationAgent::disable(ErrorString*)

@@ -69,7 +69,7 @@ void InspectorAnimationAgent::disable(ErrorString*)

for (const auto& clone : m_idToAnimationClone.values())

clone->cancel();

m_state->setBoolean(AnimationAgentState::animationAgentEnabled, false);

- m_instrumentingAgents->setInspectorAnimationAgent(nullptr);

+ m_instrumentingAgents->removeInspectorAnimationAgent(this);

m_idToAnimation.clear();

m_idToAnimationType.clear();

m_idToAnimationClone.clear();