Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
CC:
dcheng, asvitkine+watch_chromium.org, chirantan+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, loading-reviews+metrics_chromium.org, mlamouri+watch-test-runner_chromium.org, sync-reviews_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/[o-t]* from scoped_ptr to std::unique_ptr BUG=554298 R=danakj@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/82beb4ff418b0dcb40bd6b860d2e9793a0193118 Cr-Commit-Position: refs/heads/master@{#389637}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -374 lines) Patch
M components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M components/ownership/mock_owner_key_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ownership/mock_owner_key_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/ownership/owner_key_util.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/ownership/owner_settings_service.h View 4 chunks +5 lines, -4 lines 0 comments Download
M components/ownership/owner_settings_service.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.h View 1 7 chunks +10 lines, -9 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/page_load_metrics/renderer/metrics_render_frame_observer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/page_load_metrics/renderer/metrics_render_frame_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/pairing/proto_decoder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/pairing/shark_connection_listener.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/power/origin_power_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/power/origin_power_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/content/precache_manager.h View 4 chunks +3 lines, -3 lines 0 comments Download
M components/precache/content/precache_manager_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/precache/core/fetcher_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/precache/core/fetcher_pool_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M components/precache/core/precache_database.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/precache/core/precache_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M components/proxy_config/proxy_config_dictionary.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proxy_config/proxy_config_dictionary_unittest.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M components/query_parser/snippet.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/quirks/quirks_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/quirks/quirks_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/quirks/quirks_manager.h View 7 chunks +8 lines, -9 lines 0 comments Download
M components/quirks/quirks_manager.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/rappor/log_uploader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/rappor/log_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/rappor/rappor_service.h View 7 chunks +9 lines, -7 lines 0 comments Download
M components/rappor/rappor_service.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download
M components/rappor/rappor_service_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/rappor/sampler.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/rappor/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/rappor/sampler_unittest.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M components/rappor/test_rappor_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/rappor/test_rappor_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/renderer_context_menu/context_menu_delegate.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.h View 4 chunks +5 lines, -4 lines 0 comments Download
M components/renderer_context_menu/render_view_context_menu_observer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/renderer_context_menu/views/toolkit_delegate_views.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/resource_provider_test_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/rlz/rlz_tracker.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/rlz/rlz_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/rlz/rlz_tracker_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/safe_json/json_sanitizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_json/json_sanitizer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/safe_json/json_sanitizer_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M components/safe_json/safe_json_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_json/safe_json_parser_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_json/safe_json_parser_message_filter.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/safe_json/testing_json_parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/safe_json/testing_json_parser_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/search/search_android_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/search/search_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/security_interstitials/core/bad_clock_ui.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/security_interstitials/core/controller_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/security_interstitials/core/controller_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/security_interstitials/core/metrics_helper.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/session_manager/core/session_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref_unittest.cc View 9 chunks +10 lines, -11 lines 0 comments Download
M components/ssl_errors/error_classification_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/startup_metric_utils/common/pre_read_field_trial_utils_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/test_runner/app_banner_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/event_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test_runner/mock_credential_manager_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/test_runner/pixel_dump.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/test_runner/test_interfaces.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/test_runner/test_plugin.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/test_runner/test_plugin.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M components/test_runner/test_runner.h View 3 chunks +7 lines, -7 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/tracked_dictionary.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test_runner/tracked_dictionary.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/test_runner/web_frame_test_client.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/test_runner/web_frame_test_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/test_runner/web_test_interfaces.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/timers/alarm_timer_chromeos.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/timers/alarm_timer_unittest.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/tracing/child_trace_message_filter_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/tracing/process_metrics_memory_dump_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/tracing/process_metrics_memory_dump_provider.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M components/tracing/process_metrics_memory_dump_provider_unittest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M components/tracing/trace_config_file.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
+danakj for sanity review +jochen for owners review (will TBR)
4 years, 7 months ago (2016-04-25 23:07:54 UTC) #1
danakj
Spot checked LGTM
4 years, 7 months ago (2016-04-26 00:05:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921923002/20001
4 years, 7 months ago (2016-04-26 00:08:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 00:35:15 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 00:36:53 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/82beb4ff418b0dcb40bd6b860d2e9793a0193118
Cr-Commit-Position: refs/heads/master@{#389637}

Powered by Google App Engine
This is Rietveld 408576698