components/tracing/process_metrics_memory_dump_provider.h - Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/process_metrics_memory_dump_provider.h

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/tracing/child_trace_message_filter_unittest.cc ('k') | components/tracing/process_metrics_memory_dump_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/process_metrics_memory_dump_provider.h

diff --git a/components/tracing/process_metrics_memory_dump_provider.h b/components/tracing/process_metrics_memory_dump_provider.h

index b002d10fe269661e7d1c3fc77d07c77f4d5f5412..72f702a51f2cdc47f35ee6e894b54750e7973c32 100644

--- a/components/tracing/process_metrics_memory_dump_provider.h

+++ b/components/tracing/process_metrics_memory_dump_provider.h

@@ -5,9 +5,10 @@

#ifndef COMPONENTS_TRACING_PROCESS_MEMORY_METRICS_DUMP_PROVIDER_H_

#define COMPONENTS_TRACING_PROCESS_MEMORY_METRICS_DUMP_PROVIDER_H_

+#include <memory>

#include "base/gtest_prod_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/process/process_handle.h"

#include "base/trace_event/memory_dump_provider.h"

#include "build/build_config.h"

@@ -52,7 +53,7 @@ class TRACING_EXPORT ProcessMetricsMemoryDumpProvider

#endif

base::ProcessId process_;

- scoped_ptr<base::ProcessMetrics> process_metrics_;

+ std::unique_ptr<base::ProcessMetrics> process_metrics_;

// The peak may not be resettable on all the processes if the linux kernel is

// older than http://bit.ly/reset_rss or only on child processes if yama LSM