components/renderer_context_menu/render_view_context_menu_observer.h - Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_observer.h

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/renderer_context_menu/render_view_context_menu_base.h ('k') | components/renderer_context_menu/views/toolkit_delegate_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_observer.h

diff --git a/components/renderer_context_menu/render_view_context_menu_observer.h b/components/renderer_context_menu/render_view_context_menu_observer.h

index 586f978663a90c01d330ecdc1cf6b8802fab8d08..ccd052bf58cd5b5afd350374975947cefb8cbc25 100644

--- a/components/renderer_context_menu/render_view_context_menu_observer.h

+++ b/components/renderer_context_menu/render_view_context_menu_observer.h

@@ -59,12 +59,13 @@ struct ContextMenuParams;

// }

// 4. Add this observer class to the RenderViewContextMenu class. (It is good

-// to use scoped_ptr<> so Chrome can create its instances only when it needs.)

+// to use std::unique_ptr<> so Chrome can create its instances only when it

+// needs.)

// class RenderViewContextMenu {

// ...

// private:

-// scoped_ptr<MyMenuObserver> my_menu_observer_;

+// std::unique_ptr<MyMenuObserver> my_menu_observer_;

// };

// 5. Create its instance in InitMenu() and add it to the observer list of the