components/quirks/quirks_client.cc - Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/quirks/quirks_client.cc

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/quirks/quirks_client.cc

diff --git a/components/quirks/quirks_client.cc b/components/quirks/quirks_client.cc

index 93775e85f793b6be8e74165ba5458565ea97d852..383c91126a6c7bfd254c38dbb54187ce3fe06901 100644

--- a/components/quirks/quirks_client.cc

+++ b/components/quirks/quirks_client.cc

@@ -153,7 +153,7 @@ void QuirksClient::Retry() {

bool QuirksClient::ParseResult(const std::string& result, std::string* data) {

std::string data64;

const base::DictionaryValue* dict;

- scoped_ptr<base::Value> json = base::JSONReader::Read(result);

+ std::unique_ptr<base::Value> json = base::JSONReader::Read(result);

if (!json || !json->GetAsDictionary(&dict) ||

!dict->GetString("icc", &data64)) {

VLOG(1) << "Failed to parse JSON icc data";

« no previous file with comments | « components/quirks/quirks_client.h ('k') | components/quirks/quirks_manager.h » ('j') | no next file with comments »