Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.h

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
7 7
8 #include <memory>
9
8 #include "base/macros.h" 10 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 11 #include "components/page_load_metrics/common/page_load_timing.h"
11 #include "content/public/renderer/render_frame_observer.h" 12 #include "content/public/renderer/render_frame_observer.h"
12 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
13 14
14 namespace base { 15 namespace base {
15 class Timer; 16 class Timer;
16 } // namespace base 17 } // namespace base
17 18
18 namespace page_load_metrics { 19 namespace page_load_metrics {
19 20
20 class PageTimingMetricsSender; 21 class PageTimingMetricsSender;
21 22
22 // MetricsRenderFrameObserver observes RenderFrame notifications, and 23 // MetricsRenderFrameObserver observes RenderFrame notifications, and
23 // sends page load timing information to the browser process over IPC. 24 // sends page load timing information to the browser process over IPC.
24 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 25 class MetricsRenderFrameObserver : public content::RenderFrameObserver {
25 public: 26 public:
26 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 27 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
27 ~MetricsRenderFrameObserver() override; 28 ~MetricsRenderFrameObserver() override;
28 29
29 // RenderFrameObserver implementation 30 // RenderFrameObserver implementation
30 void DidChangePerformanceTiming() override; 31 void DidChangePerformanceTiming() override;
31 void DidObserveLoadingBehavior( 32 void DidObserveLoadingBehavior(
32 blink::WebLoadingBehaviorFlag behavior) override; 33 blink::WebLoadingBehaviorFlag behavior) override;
33 void DidCommitProvisionalLoad(bool is_new_navigation, 34 void DidCommitProvisionalLoad(bool is_new_navigation,
34 bool is_same_page_navigation) override; 35 bool is_same_page_navigation) override;
35 36
36 private: 37 private:
37 // Will be null when we're not actively sending metrics. 38 // Will be null when we're not actively sending metrics.
38 scoped_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; 39 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
39 40
40 void SendMetrics(); 41 void SendMetrics();
41 virtual bool ShouldSendMetrics() const; 42 virtual bool ShouldSendMetrics() const;
42 virtual PageLoadTiming GetTiming() const; 43 virtual PageLoadTiming GetTiming() const;
43 virtual scoped_ptr<base::Timer> CreateTimer() const; 44 virtual std::unique_ptr<base::Timer> CreateTimer() const;
44 virtual bool HasNoRenderFrame() const; 45 virtual bool HasNoRenderFrame() const;
45 46
46 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 47 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
47 }; 48 };
48 49
49 } // namespace page_load_metrics 50 } // namespace page_load_metrics
50 51
51 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_ 52 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698