Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.h

Issue 1921923002: Convert //components/[o-t]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_
7 7
8 #include <memory>
9
8 #include "base/macros.h" 10 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 11 #include "components/page_load_metrics/common/page_load_timing.h"
11 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 12 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
12 13
13 namespace base { 14 namespace base {
14 class Timer; 15 class Timer;
15 } // namespace base 16 } // namespace base
16 17
17 namespace IPC { 18 namespace IPC {
18 class Sender; 19 class Sender;
19 } // namespace IPC 20 } // namespace IPC
20 21
21 namespace page_load_metrics { 22 namespace page_load_metrics {
22 23
23 // PageTimingMetricsSender is responsible for sending page load timing metrics 24 // PageTimingMetricsSender is responsible for sending page load timing metrics
24 // over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to 25 // over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to
25 // minimize IPC contention. 26 // minimize IPC contention.
26 class PageTimingMetricsSender { 27 class PageTimingMetricsSender {
27 public: 28 public:
28 PageTimingMetricsSender(IPC::Sender* ipc_sender, 29 PageTimingMetricsSender(IPC::Sender* ipc_sender,
29 int routing_id, 30 int routing_id,
30 scoped_ptr<base::Timer> timer); 31 std::unique_ptr<base::Timer> timer);
31 ~PageTimingMetricsSender(); 32 ~PageTimingMetricsSender();
32 33
33 void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior); 34 void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior);
34 void Send(const PageLoadTiming& timing); 35 void Send(const PageLoadTiming& timing);
35 36
36 protected: 37 protected:
37 base::Timer* timer() const { return timer_.get(); } 38 base::Timer* timer() const { return timer_.get(); }
38 39
39 private: 40 private:
40 void EnsureSendTimer(); 41 void EnsureSendTimer();
41 void SendNow(); 42 void SendNow();
42 43
43 IPC::Sender* const ipc_sender_; 44 IPC::Sender* const ipc_sender_;
44 const int routing_id_; 45 const int routing_id_;
45 scoped_ptr<base::Timer> timer_; 46 std::unique_ptr<base::Timer> timer_;
46 PageLoadTiming last_timing_; 47 PageLoadTiming last_timing_;
47 48
48 // The the sender keep track of metadata as it comes in, because the sender is 49 // The the sender keep track of metadata as it comes in, because the sender is
49 // scoped to a single committed load. 50 // scoped to a single committed load.
50 PageLoadMetadata metadata_; 51 PageLoadMetadata metadata_;
51 52
52 DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender); 53 DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender);
53 }; 54 };
54 55
55 } // namespace page_load_metrics 56 } // namespace page_load_metrics
56 57
57 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_ 58 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_TIMING_METRICS_SENDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698