Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920263003: Rename gfx::Display/Screen to display::Display/Screen in chrome (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, asanka, jam, sadrul, asvitkine+watch_chromium.org, nektar+watch_chromium.org, dcheng, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, nona+watch_chromium.org, je_julie, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, jennb, derat+watch_chromium.org, tapted, rouslan+autofill_chromium.org, yuzo+watch_chromium.org, jianli, oshima+watch_chromium.org, kalyank, sync-reviews_chromium.org, michaelpg+watch-options_chromium.org, tfarina, shuchen+watch_chromium.org, Dmitry Titov, jdonnelly+autofillwatch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in chrome also cleanup where possible BUG=597761 Committed: https://crrev.com/d5c972ed102fa8d97a41e40221e8d687f85d5b6e Cr-Commit-Position: refs/heads/master@{#390533}

Patch Set 1 : #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -595 lines) Patch
M chrome/browser/android/banners/app_banner_data_fetcher_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/tab_content_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/feedback/screenshot_task.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/profiles/profile_downloader_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 6 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 26 chunks +67 lines, -61 lines 0 comments Download
M chrome/browser/chromeos/display/output_protection_delegate.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_web_dialog.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/display_rotation_default_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/display_rotation_default_handler.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/display_rotation_default_handler_browsertest.cc View 17 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/power/extension_event_observer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/drag_download_item_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 11 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 36 chunks +57 lines, -48 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_selector_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/thumbnails/simple_thumbnail_crop.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_positioner.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_positioner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_shower_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/popup_view_common.h View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/popup_view_common.cc View 1 4 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/ui/autofill/popup_view_common_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/ime/ime_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/display_settings_provider.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher_timer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/exclusive_access_bubble_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/link_disambiguation/link_disambiguation_popup.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_frame_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 9 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.h View 7 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 6 chunks +30 lines, -21 lines 0 comments Download
M chrome/test/base/view_event_test_platform_part_default.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920263003/20001
4 years, 7 months ago (2016-04-28 18:28:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 19:19:48 UTC) #6
oshima
4 years, 7 months ago (2016-04-28 20:02:53 UTC) #8
Lei Zhang
https://codereview.chromium.org/1920263003/diff/20001/chrome/browser/thumbnails/simple_thumbnail_crop.cc File chrome/browser/thumbnails/simple_thumbnail_crop.cc (right): https://codereview.chromium.org/1920263003/diff/20001/chrome/browser/thumbnails/simple_thumbnail_crop.cc#newcode23 chrome/browser/thumbnails/simple_thumbnail_crop.cc:23: namespace thumbnails { I'd leave the blank line after ...
4 years, 7 months ago (2016-04-28 20:13:11 UTC) #9
oshima
https://codereview.chromium.org/1920263003/diff/20001/chrome/browser/thumbnails/simple_thumbnail_crop.cc File chrome/browser/thumbnails/simple_thumbnail_crop.cc (right): https://codereview.chromium.org/1920263003/diff/20001/chrome/browser/thumbnails/simple_thumbnail_crop.cc#newcode23 chrome/browser/thumbnails/simple_thumbnail_crop.cc:23: namespace thumbnails { On 2016/04/28 20:13:10, Lei Zhang wrote: ...
4 years, 7 months ago (2016-04-28 20:19:04 UTC) #10
Lei Zhang
lgtm
4 years, 7 months ago (2016-04-28 21:18:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920263003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920263003/60001
4 years, 7 months ago (2016-04-28 22:09:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-04-28 23:17:26 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:42 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d5c972ed102fa8d97a41e40221e8d687f85d5b6e
Cr-Commit-Position: refs/heads/master@{#390533}

Powered by Google App Engine
This is Rietveld 408576698