Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
CC:
blink-reviews, kenneth.christiansen, aboxhall, eae+blinkwatch, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce isHTMLHtmlElement and toHTMLHtmlElement To avoid direct use of static_cast, this patch introduces isHTMLHtmlElement and toHTMLHtmlElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154113

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -31 lines) Patch
M Source/core/accessibility/AccessibilityRenderObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/PositionIterator.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.h View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 7 chunks +7 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-12 11:22:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19098002/1
7 years, 5 months ago (2013-07-12 11:29:58 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/html/MediaDocument.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-12 11:30:04 UTC) #3
kangil
On 2013/07/12 11:30:04, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
7 years, 5 months ago (2013-07-12 11:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19098002/7001
7 years, 5 months ago (2013-07-12 11:44:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16482
7 years, 5 months ago (2013-07-12 12:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19098002/7001
7 years, 5 months ago (2013-07-12 12:04:12 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 13:30:20 UTC) #8
Message was sent while issue was closed.
Change committed as 154113

Powered by Google App Engine
This is Rietveld 408576698