Source/core/dom/Position.cpp - Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index 61aba0102e29d8a3d93b9c6d99b07526d24c5af8..c917fb5bf97a64c57766a55d202d19a370c2d1c6 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -35,6 +35,7 @@

#include "core/editing/VisiblePosition.h"

#include "core/editing/VisibleUnits.h"

#include "core/editing/htmlediting.h"

+#include "core/html/HTMLHtmlElement.h"

#include "core/html/HTMLTableElement.h"

#include "core/platform/Logging.h"

#include "core/rendering/InlineIterator.h"

@@ -902,7 +903,7 @@ bool Position::isCandidate() const

if (isTableElement(deprecatedNode()) || editingIgnoresContent(deprecatedNode()))

return (atFirstEditingPositionForNode() || atLastEditingPositionForNode()) && !nodeIsUserSelectNone(deprecatedNode()->parentNode());

- if (m_anchorNode->hasTagName(htmlTag))

+ if (isHTMLHtmlElement(m_anchorNode.get()))

return false;

if (renderer->isBlockFlow()) {

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/PositionIterator.cpp » ('j') | no next file with comments »