Source/core/accessibility/AccessibilityRenderObject.cpp - Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityRenderObject.cpp

Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityRenderObject.cpp

diff --git a/Source/core/accessibility/AccessibilityRenderObject.cpp b/Source/core/accessibility/AccessibilityRenderObject.cpp

index 0ac0e5bf2cccdd2cddb3810d28b9c1dc2c17b6e1..bb5bf1e4d3c2090368419956975866ec0701fa2e 100644

--- a/Source/core/accessibility/AccessibilityRenderObject.cpp

+++ b/Source/core/accessibility/AccessibilityRenderObject.cpp

@@ -39,6 +39,7 @@

#include "core/editing/RenderedPosition.h"

#include "core/editing/VisibleUnits.h"

#include "core/editing/htmlediting.h"

+#include "core/html/HTMLHtmlElement.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLLabelElement.h"

#include "core/html/HTMLOptionElement.h"

@@ -432,7 +433,7 @@ AccessibilityRole AccessibilityRenderObject::determineAccessibilityRole()

return LandmarkContentInfoRole;

// The HTML element should not be exposed as an element. That's what the RenderView element does.

- if (node && node->hasTagName(htmlTag))

+ if (node && isHTMLHtmlElement(node))

return IgnoredRole;

// There should only be one banner/contentInfo per page. If header/footer are being used within an article or section

« no previous file with comments | « no previous file | Source/core/css/CSSDefaultStyleSheets.cpp » ('j') | no next file with comments »