Source/core/page/TouchDisambiguation.cpp - Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/TouchDisambiguation.cpp

Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/TouchDisambiguation.cpp

diff --git a/Source/core/page/TouchDisambiguation.cpp b/Source/core/page/TouchDisambiguation.cpp

index b13fa18848c115f69a14132f900a94bee4eabc8c..a0ba0d9f7dfe1186efc3bcec9e1bd74a80df5162 100644

--- a/Source/core/page/TouchDisambiguation.cpp

+++ b/Source/core/page/TouchDisambiguation.cpp

@@ -38,6 +38,7 @@

#include "core/dom/Document.h"

#include "core/dom/Element.h"

#include "core/dom/NodeTraversal.h"

+#include "core/html/HTMLHtmlElement.h"

#include "core/page/EventHandler.h"

#include "core/page/Frame.h"

#include "core/page/FrameView.h"

@@ -125,7 +126,7 @@ void findGoodTouchTargets(const IntRect& touchBox, Frame* mainFrame, Vector<IntR

for (Node* node = it->get(); node; node = node->parentNode()) {

if (blackList.contains(node))

continue;

- if (node->isDocumentNode() || node->hasTagName(HTMLNames::htmlTag) || node->hasTagName(HTMLNames::bodyTag))

+ if (node->isDocumentNode() || isHTMLHtmlElement(node) || node->hasTagName(HTMLNames::bodyTag))

break;

if (node->willRespondToMouseClickEvents()) {

TouchTargetData& targetData = touchTargets.add(node, TouchTargetData()).iterator->value;

« no previous file with comments | « Source/core/page/FrameView.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »