Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed)

Created:
7 years, 5 months ago by brettw
Modified:
7 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), jam, weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, tzik+watch_chromium.org, amit, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, michaeln, kinuko+watch, stevenjb+watch_chromium.org, frankf+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, kkania, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, craigdh+watch_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, ilevy-cc_chromium.org, sergeyu+watch_chromium.org, klundberg+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, Lei Zhang, tfarina, frankf, garykac+watch_chromium.org, tommycli, lambroslambrou+watch_chromium.org, robertshield, davemoore+watch_chromium.org, Greg Billock, bulach+watch_chromium.org, alexeypa+watch_chromium.org, rsimha+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211675

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -335 lines) Patch
M base/file_util.h View 1 chunk +12 lines, -12 lines 0 comments Download
M base/file_util.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M base/file_util_unittest.cc View 10 chunks +35 lines, -37 lines 0 comments Download
M base/file_util_win.cc View 1 2 4 chunks +14 lines, -13 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M base/json/json_value_serializer_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/native_library_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M base/test/test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/app_mode_loader_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_encoding_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/platform_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa/picasa_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_storage_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/auto_start_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/mac/app_mode_chrome_locator_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir_unittest.cc View 4 chunks +25 lines, -25 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/zip.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/simple_resource_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/file_metadata_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/webgl_conformance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/directory_lister.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/python_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/testserver/run_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/setup/daemon_controller_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dump_file_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/native_file_util_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webfileutilities_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years, 5 months ago (2013-07-11 18:07:59 UTC) #1
brettw
7 years, 5 months ago (2013-07-15 20:18:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r211675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698