chrome/app/app_mode_loader_mac.mm - Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/app_mode_loader_mac.mm

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/app_mode_loader_mac.mm

diff --git a/chrome/app/app_mode_loader_mac.mm b/chrome/app/app_mode_loader_mac.mm

index b5560440022111d78f2c2d1ffb7d22de9a67c287..6ca8308e1e31fa0a545c222baeabc0fab85827fc 100644

--- a/chrome/app/app_mode_loader_mac.mm

+++ b/chrome/app/app_mode_loader_mac.mm

@@ -51,7 +51,7 @@ void LoadFramework(void** cr_dylib, app_mode::ChromeAppModeInfo* info) {

NSToCFCast(cr_bundle_id)))) autorelease];

cr_bundle_path = base::mac::NSStringToFilePath(cr_bundle_path_ns);

bool found_bundle =

- !cr_bundle_path.empty() && file_util::DirectoryExists(cr_bundle_path);

+ !cr_bundle_path.empty() && base::DirectoryExists(cr_bundle_path);

if (!found_bundle) {

// If no such bundle path exists, try to search by bundle ID.

« no previous file with comments | « base/test/test_launcher.cc ('k') | chrome/browser/browser_encoding_browsertest.cc » ('j') | no next file with comments »