chrome/installer/util/self_cleaning_temp_dir.cc - Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/self_cleaning_temp_dir.cc

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/move_tree_work_item_unittest.cc ('k') | chrome/installer/util/self_cleaning_temp_dir_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/self_cleaning_temp_dir.cc

diff --git a/chrome/installer/util/self_cleaning_temp_dir.cc b/chrome/installer/util/self_cleaning_temp_dir.cc

index 8b859261acb31a6be299d765b8fd51465fb58ae2..8fddbb9dccd2eb1ba52702924565ff55c968c1d4 100644

--- a/chrome/installer/util/self_cleaning_temp_dir.cc

+++ b/chrome/installer/util/self_cleaning_temp_dir.cc

@@ -30,7 +30,7 @@ void SelfCleaningTempDir::GetTopDirToCreate(

*base_dir = parent_dir;

parent_dir = parent_dir.DirName();

} while (parent_dir != *base_dir && !base::PathExists(parent_dir));

- LOG_IF(WARNING, !file_util::DirectoryExists(parent_dir))

+ LOG_IF(WARNING, !base::DirectoryExists(parent_dir))

<< "A non-directory is at the base of the path leading to a desired "

"temp directory location: " << parent_dir.value();

}

« no previous file with comments | « chrome/installer/util/move_tree_work_item_unittest.cc ('k') | chrome/installer/util/self_cleaning_temp_dir_unittest.cc » ('j') | no next file with comments »