chrome/browser/chromeos/policy/app_pack_updater.cc - Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/app_pack_updater.cc

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc ('k') | chrome/browser/component_updater/component_patcher_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/app_pack_updater.cc

diff --git a/chrome/browser/chromeos/policy/app_pack_updater.cc b/chrome/browser/chromeos/policy/app_pack_updater.cc

index b020e86c5a6bab2fb8f331611b28988cbfb0d1e1..feb595098220e09cea2e24d451c89782b79a2b27 100644

--- a/chrome/browser/chromeos/policy/app_pack_updater.cc

+++ b/chrome/browser/chromeos/policy/app_pack_updater.cc

@@ -240,7 +240,7 @@ void AppPackUpdater::BlockingCheckCacheInternal(

CacheEntryMap* entries) {

// Start by verifying that the cache dir exists.

base::FilePath dir(kAppPackCacheDir);

- if (!file_util::DirectoryExists(dir)) {

+ if (!base::DirectoryExists(dir)) {

// Create it now.

if (!file_util::CreateDirectory(dir))

LOG(ERROR) << "Failed to create AppPack directory at " << dir.value();

@@ -484,7 +484,7 @@ void AppPackUpdater::BlockingInstallCacheEntry(

base::Delete(cached_crx_path, true /* recursive */);

}

- if (!file_util::DirectoryExists(cache_dir)) {

+ if (!base::DirectoryExists(cache_dir)) {

LOG(ERROR) << "AppPack cache directory does not exist, creating now: "

<< cache_dir.value();

if (!file_util::CreateDirectory(cache_dir)) {