chrome/browser/extensions/api/storage/managed_value_store_cache.cc - Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/managed_value_store_cache.cc

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/record/record_api_test.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/managed_value_store_cache.cc

diff --git a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc

index a64fc19d89d05a80e71184195d422f91475727c9..6184cfc08e6f873250dfe37c5a94b108e2356771 100644

--- a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc

+++ b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc

@@ -235,7 +235,7 @@ void ManagedValueStoreCache::DeleteStorageSoon(

// (because the extension is unloaded, for example). Open the database to

// clear it if it exists.

// TODO(joaodasilva): move this check to a ValueStore method.

- if (file_util::DirectoryExists(base_path_.AppendASCII(extension_id))) {

+ if (base::DirectoryExists(base_path_.AppendASCII(extension_id))) {

CreateStoreFor(

extension_id,

false,

@@ -383,7 +383,7 @@ void ManagedValueStoreCache::CreateStoreWithInitialPolicy(

// If the database doesn't exist yet then this is the initial install,

// and no notifications should be issued in that case.

// TODO(joaodasilva): move this check to a ValueStore method.

- if (!file_util::DirectoryExists(base_path_.AppendASCII(extension_id)))

+ if (!base::DirectoryExists(base_path_.AppendASCII(extension_id)))

notify_if_changed = false;

store = new PolicyValueStore(