Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856
Committed: https://crrev.com/4a3b5f099c7831d163fbafde81f618b90736ceb4
Cr-Commit-Position: refs/heads/master@{#393555}

[hiroshige, 2016-04-22 11:07:21]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 11:07:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/1

[commit-bot: I haz the power, 2016-04-22 12:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 12:09:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-04-22 12:27:02]

Description was changed from

==========
Disallow raw pointers in CrossThreadCopier/threadSafeBind()

BUG=
==========

to

==========
Disallow raw pointers in CrossThreadCopier/threadSafeBind()

BUG=
==========

[hiroshige, 2016-04-22 12:27:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 12:27:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/20001

[commit-bot: I haz the power, 2016-04-22 13:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:55:24]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-26 11:48:05]

Description was changed from

==========
Disallow raw pointers in CrossThreadCopier/threadSafeBind()

BUG=
==========

to

==========
Replace CrossThreadCopier/threadSafeBind() + GCed pointers with
crossThreadRetainedRef()

BUG=
==========

[hiroshige, 2016-04-27 05:24:39]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 05:24:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/40001

[hiroshige, 2016-04-27 05:26:44]

Description was changed from

==========
Replace CrossThreadCopier/threadSafeBind() + GCed pointers with
crossThreadRetainedRef()

BUG=
==========

to

==========
Replace CrossThreadCopier/threadSafeBind() + GCed pointers with
crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

BUG=597856
==========

[hiroshige, 2016-04-27 05:27:26]

Description was changed from

==========
Replace CrossThreadCopier/threadSafeBind() + GCed pointers with
crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

BUG=597856
==========

[commit-bot: I haz the power, 2016-04-27 05:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 05:34:23]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[hiroshige, 2016-04-27 05:51:02]

Description was changed from

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

In replacing,
- all uses of threadSafeBind() + GCed pointers are detected by compile errors
(due to lack of CrossThreadCopier), and
- all uses of threadSafeBind() + crossThreadRetainedRef() are for GCed pointers
(crossThreadRetainedRef() only accepts GCed pointers).

BUG=597856
==========

[hiroshige, 2016-04-27 05:51:39]

Description was changed from

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

In replacing,
- all uses of threadSafeBind() + GCed pointers are detected by compile errors
(due to lack of CrossThreadCopier), and
- all uses of threadSafeBind() + crossThreadRetainedRef() are for GCed pointers
(crossThreadRetainedRef() only accepts GCed pointers).

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

In replacing,
- All previous uses of threadSafeBind() + GCed pointers are detected by
  compile errors (due to lack of CrossThreadCopier), and
- All current uses of threadSafeBind() + crossThreadRetainedRef() are for GCed
  pointers (crossThreadRetainedRef() only accepts GCed pointers).

BUG=597856
==========

[hiroshige, 2016-04-27 06:30:00]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 06:30:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/40001

[commit-bot: I haz the power, 2016-04-27 06:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 06:47:43]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-27 09:27:15]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 09:27:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/60001

[commit-bot: I haz the power, 2016-04-27 12:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 12:56:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-05-13 06:30:02]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 06:30:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/80001

[commit-bot: I haz the power, 2016-05-13 07:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 07:57:55]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-13 08:08:14]

Description was changed from

==========
Replace threadSafeBind() + GCed pointers with crossThreadRetainedRef()

Disable GCed raw pointers in threadSafeBind(), use crossThreadRetainedRef()
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadRetainedRefWrapper

In replacing,
- All previous uses of threadSafeBind() + GCed pointers are detected by
  compile errors (due to lack of CrossThreadCopier), and
- All current uses of threadSafeBind() + crossThreadRetainedRef() are for GCed
  pointers (crossThreadRetainedRef() only accepts GCed pointers).

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856
==========

[hiroshige, 2016-05-13 08:24:05]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org, tzik@chromium.org

[hiroshige, 2016-05-13 08:24:06]

PTAL.

[haraken, 2016-05-13 09:02:06]

LGTM

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
(right):

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp:207:
Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE,
threadSafeBind(&BlobCallback::handleEvent,
wrapCrossThreadPersistent(m_callback.get()), nullptr));

Do we need get()?

[tzik, 2016-05-13 09:09:08]

lgtm

[kinuko, 2016-05-13 09:27:28]

lgtm

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp (right):

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp:56:
m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE,
threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioData),
sampleRate, wrapCrossThreadPersistent(successCallback),
wrapCrossThreadPersistent(errorCallback), wrapCrossThreadPersistent(resolver),
wrapCrossThreadPersistent(context)));
If it's not too much work could we break lines for some of these looong lines? 
(Fine to keep as is in this patch too)

[hiroshige, 2016-05-13 10:45:02]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 10:45:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/100001

[commit-bot: I haz the power, 2016-05-13 10:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 10:56:01]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[hiroshige, 2016-05-13 16:46:02]

Patchset #6 (id:100001) has been deleted

[hiroshige, 2016-05-13 16:47:19]

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
(right):

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp:207:
Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE,
threadSafeBind(&BlobCallback::handleEvent,
wrapCrossThreadPersistent(m_callback.get()), nullptr));
On 2016/05/13 09:02:06, haraken wrote:
> 
> Do we need get()?

Yes, type of T* is currently needed for wrapCrossThreadPersistent() to deduce
typename T.

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp (right):

https://codereview.chromium.org/1904283004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp:56:
m_thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE,
threadSafeBind(&AsyncAudioDecoder::decode, AllowCrossThreadAccess(audioData),
sampleRate, wrapCrossThreadPersistent(successCallback),
wrapCrossThreadPersistent(errorCallback), wrapCrossThreadPersistent(resolver),
wrapCrossThreadPersistent(context)));
On 2016/05/13 09:27:27, kinuko wrote:
> If it's not too much work could we break lines for some of these looong lines?

> (Fine to keep as is in this patch too)

I'll keep this as-is to make the changes mechanical as much as possible.

[hiroshige, 2016-05-13 16:47:46]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-05-13 16:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904283004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904283004/80001

[commit-bot: I haz the power, 2016-05-13 16:56:06]

Description was changed from

==========
Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856
==========

[commit-bot: I haz the power, 2016-05-13 16:56:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-13 16:57:43]

Description was changed from

==========
Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856
==========

to

==========
Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Disable GCed raw pointers in threadSafeBind(), use CrossThreadPersistent
instead:
- Remove CrossThreadCopier for GCed raw pointers
- Introduce CrossThreadCopier for CrossThreadPersistent
- Apply wrapCrossThreadPersistent() to GCed raw pointers

BUG=597856

Committed: https://crrev.com/4a3b5f099c7831d163fbafde81f618b90736ceb4
Cr-Commit-Position: refs/heads/master@{#393555}
==========

[commit-bot: I haz the power, 2016-05-13 16:57:44]

Patchset 5 (id:??) landed as
https://crrev.com/4a3b5f099c7831d163fbafde81f618b90736ceb4
Cr-Commit-Position: refs/heads/master@{#393555}