third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp - Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp1912053002

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

index 81efe6d14d3a3d7cd3f08585c4dad448fc8024a1..7d4bce68824a6995706d101f3a3baef8307d7dad 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

@@ -204,7 +204,7 @@ void CanvasAsyncBlobCreator::encodeImageOnEncoderThread(double quality)

success = ImageDataBuffer(m_size, m_data->data()).encodeImage(m_mimeType, quality, m_encodedImage.get());

if (!success) {

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&BlobCallback::handleEvent, m_callback.get(), nullptr));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&BlobCallback::handleEvent, wrapCrossThreadPersistent(m_callback.get()), nullptr));

haraken 2016/05/13 09:02:06 Do we need get()?

hiroshige 2016/05/13 16:47:19 Yes, type of T* is currently needed for wrapCrossT

return;

}