Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1923813002:
Introduce wrapPersistent()/wrapCrossThreadPersistent() (Closed)
|
Created:
4 years, 7 months ago by hiroshige Modified:
4 years, 7 months ago CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, kinuko+watch, kouhei+heap_chromium.org, oilpan-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce wrapPersistent()/wrapCrossThreadPersistent()
These wrappers are for constructing Persistent/CrossThreadPersistent from
raw pointers without writing typenames explicitly.
These will be used by subsequent CLs for Issue 597856.
BUG=597856
Committed: https://crrev.com/a6d7b889ea801601b494d5433cc68c4018cda457
Cr-Commit-Position: refs/heads/master@{#393490}
Patch Set 1 #Patch Set 2 : auto-Rebase #Patch Set 3 : wrapPersistent() #Patch Set 4 : Rebase #
Dependent Patchsets: Messages
Total messages: 33 (17 generated)
Description was changed from ========== Add blink::retainedRef() and blink::crossThreadRetainedRef() for GCed pointers BUG= ========== to ========== Introduce blink::retainedRef()/crossThreadRetainedRef() for GCed pointers BUG=597856 ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/60001
Description was changed from ========== Introduce blink::retainedRef()/crossThreadRetainedRef() for GCed pointers BUG=597856 ========== to ========== Introduce wrapPersistent/wrapCrossThreadPersistent These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ==========
hiroshige@chromium.org changed reviewers: + haraken@chromium.org, tzik@chromium.org
Description was changed from ========== Introduce wrapPersistent/wrapCrossThreadPersistent These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ========== to ========== Introduce wrapPersistent()/wrapCrossThreadPersistent() These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ==========
PTAL.
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923813002/60001
Message was sent while issue was closed.
Description was changed from ========== Introduce wrapPersistent()/wrapCrossThreadPersistent() These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ========== to ========== Introduce wrapPersistent()/wrapCrossThreadPersistent() These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Introduce wrapPersistent()/wrapCrossThreadPersistent() These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 ========== to ========== Introduce wrapPersistent()/wrapCrossThreadPersistent() These wrappers are for constructing Persistent/CrossThreadPersistent from raw pointers without writing typenames explicitly. These will be used by subsequent CLs for Issue 597856. BUG=597856 Committed: https://crrev.com/a6d7b889ea801601b494d5433cc68c4018cda457 Cr-Commit-Position: refs/heads/master@{#393490} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/a6d7b889ea801601b494d5433cc68c4018cda457 Cr-Commit-Position: refs/heads/master@{#393490} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
