third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp - Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp1912053002

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp ('k') | third_party/WebKit/Source/platform/CrossThreadCopier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp b/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

index d49a6126d75856b6990f8cceab7f08f828acedd4..8d55428bc69149228abb98e26807081a8dcfb8ac 100644

--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp

@@ -65,7 +65,7 @@ void DatabaseThread::start()

if (m_thread)

return;

m_thread = WebThreadSupportingGC::create("WebCore: Database");

- m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::setupDatabaseThread, this));

+ m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::setupDatabaseThread, wrapCrossThreadPersistent(this)));

}

void DatabaseThread::setupDatabaseThread()

@@ -83,7 +83,7 @@ void DatabaseThread::terminate()

m_terminationRequested = true;

m_cleanupSync = &sync;

WTF_LOG(StorageAPI, "DatabaseThread %p was asked to terminate\n", this);

- m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::cleanupDatabaseThread, this));

+ m_thread->postTask(BLINK_FROM_HERE, threadSafeBind(&DatabaseThread::cleanupDatabaseThread, wrapCrossThreadPersistent(this)));

}

sync.waitForTaskCompletion();

// The WebThread destructor blocks until all the tasks of the database