third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp - Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

Issue 1904283004: Replace threadSafeBind() + GCed pointers with CrossThreadPersistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp1912053002

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp ('K') | « third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

index c89b30cddafc739a32bd0886af0b27c2837dd8b9..d61455f40b63eadf04b50d890a0b1956886299ee 100644

--- a/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

@@ -799,7 +799,7 @@ void AbstractAudioContext::releaseFinishedSourceNodes()

}

if (didRemove)

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&AbstractAudioContext::removeFinishedSourceNodes, this));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&AbstractAudioContext::removeFinishedSourceNodes, wrapCrossThreadPersistent(this)));

m_finishedSourceHandlers.clear();

}

@@ -909,7 +909,7 @@ void AbstractAudioContext::resolvePromisesForResume()

// promises in the main thread.

if (!m_isResolvingResumePromises && m_resumeResolvers.size() > 0) {

m_isResolvingResumePromises = true;

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&AbstractAudioContext::resolvePromisesForResumeOnMainThread, this));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&AbstractAudioContext::resolvePromisesForResumeOnMainThread, wrapCrossThreadPersistent(this)));

}