Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
Committed: https://crrev.com/4c6e26cd4be4f511aa6a62e46c37178605fb3714
Cr-Commit-Position: refs/heads/master@{#393573}

[hiroshige, 2016-03-05 01:00:40]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-05 01:00:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/1

[commit-bot: I haz the power, 2016-03-05 01:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-05 01:04:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-03-05 02:16:28]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-05 02:17:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/20001

[commit-bot: I haz the power, 2016-03-05 03:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-05 03:42:57]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-22 11:17:47]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 11:17:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/80001

[commit-bot: I haz the power, 2016-04-22 11:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 11:57:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-04-22 12:28:25]

Description was changed from

==========
Do not apply AllowCrossThreadAccess() inside createCrossThreadTask()

BUG=
==========

to

==========
Do not apply AllowCrossThreadAccess() inside createCrossThreadTask()

BUG=
==========

[hiroshige, 2016-04-22 12:30:06]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 12:30:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/100001

[commit-bot: I haz the power, 2016-04-22 15:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 15:28:21]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-26 11:45:43]

Description was changed from

==========
Do not apply AllowCrossThreadAccess() inside createCrossThreadTask()

BUG=
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

BUG=
==========

[hiroshige, 2016-04-27 05:39:29]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 05:39:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/120001

[hiroshige, 2016-04-27 06:29:47]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

BUG=
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

In replacing,
- All previous uses of createCrossThreadTask() that would require
  AllowCrossThreadAccess() are detected by compile errors
  (due to lack of CrossThreadCopier for WeakPtr/pointers by
  https://codereview.chromium.org/1904283004/), and
- No current uses of AllowCrossThreadAccess() in createCrossThreadTask()
  can't be applied to arguments to which AllowCrossThreadAccess() were not
  applied (such arguments would be pointers or WeakPtr but would have been
  rejected due to lack of CrossThreadCopier for WeakPtr/pointers).

BUG=597856
==========

[commit-bot: I haz the power, 2016-04-27 07:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 07:13:13]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-27 09:27:18]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 09:27:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/140001

[commit-bot: I haz the power, 2016-04-27 11:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 11:26:00]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-13 06:32:23]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 06:32:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/160001

[commit-bot: I haz the power, 2016-05-13 07:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 07:50:53]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-13 08:29:23]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

In replacing,
- All previous uses of createCrossThreadTask() that would require
  AllowCrossThreadAccess() are detected by compile errors
  (due to lack of CrossThreadCopier for WeakPtr/pointers by
  https://codereview.chromium.org/1904283004/), and
- No current uses of AllowCrossThreadAccess() in createCrossThreadTask()
  can't be applied to arguments to which AllowCrossThreadAccess() were not
  applied (such arguments would be pointers or WeakPtr but would have been
  rejected due to lack of CrossThreadCopier for WeakPtr/pointers).

BUG=597856
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

[hiroshige, 2016-05-13 08:30:53]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossTHreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

[hiroshige, 2016-05-13 08:32:17]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org, tzik@chromium.org,
yutak@chromium.org

[hiroshige, 2016-05-13 08:32:18]

PTAL.

FYI yutak@ as this CL removes enable_if conditions that you added in
CrossThreadTask.h.

[tzik, 2016-05-13 09:15:49]

lgtm

[haraken, 2016-05-13 09:17:14]

LGTM

[kinuko, 2016-05-13 09:24:07]

lgtm!

[Yuta Kitamura, 2016-05-13 09:36:44]

LGTM

[hiroshige, 2016-05-13 17:41:57]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossTHreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

[hiroshige, 2016-05-13 17:42:17]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-05-13 17:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766143002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766143002/160001

[commit-bot: I haz the power, 2016-05-13 17:50:00]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

[commit-bot: I haz the power, 2016-05-13 17:50:01]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-05-13 17:51:33]

Description was changed from

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856
==========

to

==========
Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()

This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies
AllowCrossThreadAccess() at the callers of createCrossThreadAccess().

All previous uses of createCrossThreadTask() that would require
AllowCrossThreadAccess() are detected by compile errors
due to lack of CrossThreadCopier for WeakPtr/pointers because
https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for
GCed pointers.

BUG=597856

Committed: https://crrev.com/4c6e26cd4be4f511aa6a62e46c37178605fb3714
Cr-Commit-Position: refs/heads/master@{#393573}
==========

[commit-bot: I haz the power, 2016-05-13 17:51:35]

Patchset 9 (id:??) landed as
https://crrev.com/4c6e26cd4be4f511aa6a62e46c37178605fb3714
Cr-Commit-Position: refs/heads/master@{#393573}

[Finnur, 2016-05-17 12:24:38]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/1986143002/ by finnur@chromium.org.

The reason for reverting is: Speculatively reverting this to see if it fixes a
bunch of media tests on Windows that started failing as soon as this was checked
in.

Started here:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%....

[Finnur, 2016-05-17 12:39:26]

Revert aborted because patch failed to apply. 

hiroshige: Please take a look a the media failures (link in previous comment).
Would file a new bug, but our bug repository seems to be own at the moment.

[hiroshige, 2016-05-17 13:00:57]

On 2016/05/17 12:39:26, Finnur wrote:
> Revert aborted because patch failed to apply. 
> 
> hiroshige: Please take a look a the media failures (link in previous comment).
> Would file a new bug, but our bug repository seems to be own at the moment.

I'll create a new crbug entry but currently crbug is down.
Suspected CL is https://codereview.chromium.org/1974373002 and there is
discussion in the comments there.

[hiroshige, 2016-05-17 13:55:29]

On 2016/05/17 13:00:57, hiroshige wrote:
> On 2016/05/17 12:39:26, Finnur wrote:
> > Revert aborted because patch failed to apply. 
> > 
> > hiroshige: Please take a look a the media failures (link in previous
comment).
> > Would file a new bug, but our bug repository seems to be own at the moment.
> 
> I'll create a new crbug entry but currently crbug is down.
> Suspected CL is https://codereview.chromium.org/1974373002 and there is
> discussion in the comments there.

Filed https://crbug.com/612442.