Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899783003: MIPS: [Atomics] Remove Atomics code stubs; use TF ops. (Closed)

Created:
4 years, 8 months ago by akos.palfi.imgtec
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [Atomics] Remove Atomics code stubs; use TF ops. Port d412cfa26c18a6ef1f6c0e274ee51f3d834eab74 BUG= Committed: https://crrev.com/efadbfc458519848509136014e4b9e8435d379ea Cr-Commit-Position: refs/heads/master@{#35613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -15 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/constants-mips.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/constants-mips64.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
akos.palfi.imgtec
PTAL.
4 years, 8 months ago (2016-04-19 01:14:48 UTC) #2
akos.palfi.imgtec
PTAL.
4 years, 8 months ago (2016-04-19 01:20:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899783003/1
4 years, 8 months ago (2016-04-19 01:20:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 01:46:37 UTC) #8
miran.karic
lgtm
4 years, 8 months ago (2016-04-19 07:46:51 UTC) #9
balazs.kilvady
l-g-t-m
4 years, 8 months ago (2016-04-19 10:54:22 UTC) #10
balazs.kilvady
LGTM
4 years, 8 months ago (2016-04-19 11:01:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899783003/1
4 years, 8 months ago (2016-04-19 11:02:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 11:21:29 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 11:22:58 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/efadbfc458519848509136014e4b9e8435d379ea
Cr-Commit-Position: refs/heads/master@{#35613}

Powered by Google App Engine
This is Rietveld 408576698