Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898153002: Migrate notifications to use the PermissionStatus enum (Closed)

Created:
4 years, 8 months ago by Peter Beverloo
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, haraken, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate notifications to use the PermissionStatus enum TBR=mkwst for NotificationPermissionClientImpl.cpp BUG=595685 Committed: https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973 Cr-Commit-Position: refs/heads/master@{#388279}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : rebase + remove outdated deps lines #

Patch Set 4 : fix the platformnotificationservice tests #

Total comments: 2

Patch Set 5 : fix type traits conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -128 lines) Patch
M chrome/browser/notifications/platform_notification_service_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/notifications/notification_message_filter.h View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 2 7 chunks +12 lines, -10 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/notifications/notification_manager.cc View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M content/common/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/platform_notification_messages.h View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
M content/public/browser/platform_notification_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 4 chunks +5 lines, -20 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationPermission.h View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1901133002 Patch 20001

Dependent Patchsets:

Issue 1898193003 Patch 1

Messages

Total messages: 16 (8 generated)
Peter Beverloo
+mvanouwerkerk for notifications +avi for //content API + DEPS https://codereview.chromium.org/1898153002/diff/20001/content/child/notifications/notification_manager.cc File content/child/notifications/notification_manager.cc (right): https://codereview.chromium.org/1898153002/diff/20001/content/child/notifications/notification_manager.cc#newcode216 content/child/notifications/notification_manager.cc:216: ...
4 years, 8 months ago (2016-04-19 14:54:02 UTC) #2
Avi (use Gerrit)
lgtm stampity stamp
4 years, 8 months ago (2016-04-19 15:49:40 UTC) #3
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/1898153002/diff/60001/content/browser/notifications/notification_message_filter.h File content/browser/notifications/notification_message_filter.h (right): https://codereview.chromium.org/1898153002/diff/60001/content/browser/notifications/notification_message_filter.h#newcode58 content/browser/notifications/notification_message_filter.h:58: blink::mojom::PermissionStatus* permission); nit: s/permission/permission_status/ for consistency ...
4 years, 8 months ago (2016-04-19 16:34:04 UTC) #4
Peter Beverloo
+tsepez@chromium.org for platform_notification_messages.h, layout_test_messages.h and common_param_traits_macros.h https://codereview.chromium.org/1898153002/diff/60001/content/browser/notifications/notification_message_filter.h File content/browser/notifications/notification_message_filter.h (right): https://codereview.chromium.org/1898153002/diff/60001/content/browser/notifications/notification_message_filter.h#newcode58 content/browser/notifications/notification_message_filter.h:58: blink::mojom::PermissionStatus* permission); On ...
4 years, 8 months ago (2016-04-19 17:19:38 UTC) #6
Tom Sepez
messages/traits LGTM.
4 years, 8 months ago (2016-04-19 17:25:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898153002/80001
4 years, 8 months ago (2016-04-19 18:52:49 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-19 19:34:10 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:10 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973
Cr-Commit-Position: refs/heads/master@{#388279}

Powered by Google App Engine
This is Rietveld 408576698