third_party/WebKit/Source/modules/notifications/Notification.h - Issue 1898153002: Migrate notifications to use the PermissionStatus enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1898153002: Migrate notifications to use the PermissionStatus enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix type traits conflicts Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/common/layout_test/layout_test_messages.h ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index e3e0b628dab804689b65fa9979f03b04573123e7..cf5c627b6ea058e3acdae6211829e286875ba0bf 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -46,7 +46,7 @@

#include "public/platform/WebVector.h"

#include "public/platform/modules/notifications/WebNotificationData.h"

#include "public/platform/modules/notifications/WebNotificationDelegate.h"

-#include "public/platform/modules/notifications/WebNotificationPermission.h"

+#include "public/platform/modules/permissions/permission_status.mojom.h"

namespace blink {

@@ -99,9 +99,9 @@ public:

ScriptValue data(ScriptState*);

HeapVector<NotificationAction> actions() const;

- static String permissionString(WebNotificationPermission);

+ static String permissionString(mojom::PermissionStatus);

static String permission(ExecutionContext*);

- static WebNotificationPermission checkPermission(ExecutionContext*);

+ static mojom::PermissionStatus checkPermission(ExecutionContext*);

static ScriptPromise requestPermission(ScriptState*, NotificationPermissionCallback*);

static size_t maxActions();