Move the notification constants to Blink

Move the notification constants to Blink

With Notifications departing from //content on the renderer side we need
a place where we can access them. The long-term goal however is for the
embedder to indicate these constants, for which I added TODOs.

BUG=595685
Committed: https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2
Cr-Commit-Position: refs/heads/master@{#388236}

[Peter Beverloo, 2016-04-19 15:46:36]

peter@chromium.org changed reviewers:
+ avi@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2016-04-19 15:46:37]

+mvanouwerkerk for notifications
+avi for //content changes

[Avi (use Gerrit), 2016-04-19 15:48:43]

lgtm

stampity stamp

[Michael van Ouwerkerk, 2016-04-19 16:23:34]

lgtm with the comment addressed

https://codereview.chromium.org/1901133002/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h
(right):

https://codereview.chromium.org/1901133002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h:21:
static const int kWebNotificationMaxIconSizePx = 320; // 80 dip * 4
NotificationResourcesLoader should use these now, it has a copy of them.

[Peter Beverloo, 2016-04-19 16:29:58]

Done, thanks!

[Peter Beverloo, 2016-04-19 16:30:28]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-04-19 16:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1901133002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-19 16:30:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901133002/20001

[commit-bot: I haz the power, 2016-04-19 17:37:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:13:28]

Description was changed from

==========
Move the notification constants to Blink

With Notifications departing from //content on the renderer side we need
a place where we can access them. The long-term goal however is for the
embedder to indicate these constants, for which I added TODOs.

BUG=595685
==========

to

==========
Move the notification constants to Blink

With Notifications departing from //content on the renderer side we need
a place where we can access them. The long-term goal however is for the
embedder to indicate these constants, for which I added TODOs.

BUG=595685

Committed: https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2
Cr-Commit-Position: refs/heads/master@{#388236}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:29]

Patchset 2 (id:??) landed as
https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2
Cr-Commit-Position: refs/heads/master@{#388236}