third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h - Issue 1898153002: Migrate notifications to use the PermissionStatus enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Issue 1898153002: Migrate notifications to use the PermissionStatus enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix type traits conflicts Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationPermission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

diff --git a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

index 4cad4c8063ad46d774985799da6d3069d779e243..1e6ced998917d81643b2eb59103767b23398ac53 100644

--- a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

+++ b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

@@ -9,13 +9,16 @@

#include "public/platform/WebString.h"

#include "public/platform/WebVector.h"

#include "public/platform/modules/notifications/WebNotificationData.h"

-#include "public/platform/modules/notifications/WebNotificationPermission.h"

#include "public/platform/modules/notifications/WebNotificationResources.h"

#include <memory>

#include <stdint.h>

namespace blink {

+namespace mojom {

+enum class PermissionStatus;

class WebNotificationDelegate;

class WebSecurityOrigin;

class WebServiceWorkerRegistration;

@@ -59,7 +62,7 @@ public:

virtual void notifyDelegateDestroyed(WebNotificationDelegate*) = 0;

// Synchronously checks the permission level for the given origin.

- virtual WebNotificationPermission checkPermission(const WebSecurityOrigin&) = 0;

+ virtual mojom::PermissionStatus checkPermission(const WebSecurityOrigin&) = 0;

};

} // namespace blink