Add type converters from Mojo notifications to the content types

Add type converters from Mojo notifications to the content types

These are (very) temporary because we'll use the Mojo types everywhere,
but they'll make the initial transition to Mojo significantly easier.

BUG=595685
Committed: https://crrev.com/df302aa7b01065c6343d0bd11b3e9500d322e3eb
Cr-Commit-Position: refs/heads/master@{#388590}

[Peter Beverloo, 2016-04-19 18:51:11]

peter@chromium.org changed reviewers:
+ jam@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2016-04-19 18:51:12]

+mvanouwerkerk for notifications
+jam for //content/browser/DEPS addition (mojom header)

This will be hooked up in a later CL, but it decreases the size of that (rapidly
growing) one by another ~300 lines.

Quickly after that CL it will be removed again, as the //chrome notification
users will also be updated to use the mojom file.

[Michael van Ouwerkerk, 2016-04-20 10:20:09]

lgtm with nits

https://codereview.chromium.org/1898193003/diff/1/content/browser/notificatio...
File content/browser/notifications/type_converters_unittest.cc (right):

https://codereview.chromium.org/1898193003/diff/1/content/browser/notificatio...
content/browser/notifications/type_converters_unittest.cc:31:
notification_data.vibration_pattern.push_back(45);
It seems a bit random to set two items in the pattern, set some unrelated
properties, and then add some more to the pattern.

https://codereview.chromium.org/1898193003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/notifications/notification.mojom
(right):

https://codereview.chromium.org/1898193003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/notifications/notification.mojom:27:
// Placeholder to display for text-based actions in absense of user input.
nit: s/absense/absence/

[Peter Beverloo, 2016-04-20 12:45:54]

https://codereview.chromium.org/1898193003/diff/1/content/browser/notificatio...
File content/browser/notifications/type_converters_unittest.cc (right):

https://codereview.chromium.org/1898193003/diff/1/content/browser/notificatio...
content/browser/notifications/type_converters_unittest.cc:31:
notification_data.vibration_pattern.push_back(45);
On 2016/04/20 10:20:09, Michael van Ouwerkerk wrote:
> It seems a bit random to set two items in the pattern, set some unrelated
> properties, and then add some more to the pattern.

Erps, that's meant to say `data`. Fixed.

https://codereview.chromium.org/1898193003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/notifications/notification.mojom
(right):

https://codereview.chromium.org/1898193003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/notifications/notification.mojom:27:
// Placeholder to display for text-based actions in absense of user input.
On 2016/04/20 10:20:09, Michael van Ouwerkerk wrote:
> nit: s/absense/absence/

Done.

[jam, 2016-04-20 16:39:59]

lgtm

[Peter Beverloo, 2016-04-20 22:40:19]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-04-20 22:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1898193003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-20 22:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898193003/20001

[commit-bot: I haz the power, 2016-04-20 23:24:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:27:04]

Description was changed from

==========
Add type converters from Mojo notifications to the content types

These are (very) temporary because we'll use the Mojo types everywhere,
but they'll make the initial transition to Mojo significantly easier.

BUG=595685
==========

to

==========
Add type converters from Mojo notifications to the content types

These are (very) temporary because we'll use the Mojo types everywhere,
but they'll make the initial transition to Mojo significantly easier.

BUG=595685

Committed: https://crrev.com/df302aa7b01065c6343d0bd11b3e9500d322e3eb
Cr-Commit-Position: refs/heads/master@{#388590}
==========

[commit-bot: I haz the power, 2016-04-22 19:27:05]

Patchset 2 (id:??) landed as
https://crrev.com/df302aa7b01065c6343d0bd11b3e9500d322e3eb
Cr-Commit-Position: refs/heads/master@{#388590}