third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp - Issue 1898153002: Migrate notifications to use the PermissionStatus enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

Issue 1898153002: Migrate notifications to use the PermissionStatus enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix type traits conflicts Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | third_party/WebKit/public/blink_headers.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp b/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

index 2a9c7f15d09b9ddcb438fe006dedda70861f527e..b26b3d8065842cbc2527017a7da8461be6cd14ea 100644

--- a/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

+++ b/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp

@@ -28,9 +28,9 @@ public:

~WebNotificationPermissionCallbackImpl() override { }

- void permissionRequestComplete(WebNotificationPermission permission) override

+ void permissionRequestComplete(mojom::PermissionStatus permissionStatus) override

{

- String permissionString = Notification::permissionString(permission);

+ String permissionString = Notification::permissionString(permissionStatus);

if (m_deprecatedCallback)

m_deprecatedCallback->handleEvent(permissionString);