Adds WmWindow and converts WindowState to use it

Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org

Committed: https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a
Cr-Commit-Position: refs/heads/master@{#387626}

[sky, 2016-04-14 03:37:40]

The interesting parts are in WindowState and WmWindow. The rest of the changes
are because I moved aura specific calls to window_state_aura, and I renamed
WindowState::window() to WindowState::aura_window. I will eventually get rid of
the later call.

I ended up creating functions for many things rather than using properties. Part
of the problem with properties is that I can't use the same property between
aura and mus.

I also made CreateDragDetails not take a window as its first arg. All callers
supplied the window matching the windowstate, so it wasn't necessary.

My plan is to move all files that don't depend upon aura into ash/wm/common.

[oshima, 2016-04-15 14:47:59]

lgtm with one question.

https://codereview.chromium.org/1890713002/diff/100001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/1890713002/diff/100001/ash/wm/window_state.h#...
ash/wm/window_state.h:35: class WmWindow;
Am I correct that when transition is complete, this will be gone and wm will use
mus::Window directly?

I believe launcher/shelf code are also (currently) using aura::Window. How
they're dealing with the difference?

[sky, 2016-04-15 15:20:34]

https://codereview.chromium.org/1890713002/diff/100001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/1890713002/diff/100001/ash/wm/window_state.h#...
ash/wm/window_state.h:35: class WmWindow;
On 2016/04/15 14:47:59, oshima wrote:
> Am I correct that when transition is complete, this will be gone and wm will
use
> mus::Window directly?

Yes, that is the goal. Although we could decide this layer (WmWindow) is useful
as a way to encapsulate how the windowmanager operates on  windows. For example,
many of the functions on WindowState feel like they would be better placed on
WmWindow.

> I believe launcher/shelf code are also (currently) using aura::Window. How
> they're dealing with the difference? 

All code that makes sense to be in the windowmanager will be converted to use
WmWindow. The remaining code likely needs to change anyway.

[sky, 2016-04-15 15:20:49]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-04-15 15:21:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890713002/100001

[commit-bot: I haz the power, 2016-04-15 15:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 15:29:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-04-15 15:51:59]

Description was changed from

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
==========

to

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org
==========

[sky, 2016-04-15 15:51:59]

sky@chromium.org changed reviewers:
+ reveman@chromium.org

[sky, 2016-04-15 15:55:16]

TBR reveman for components/exo/shell_surface.cc

[sky, 2016-04-15 15:59:13]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-15 15:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1890713002/#ps120001
(title: "merge again")

[commit-bot: I haz the power, 2016-04-15 15:59:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890713002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890713002/120001

[commit-bot: I haz the power, 2016-04-15 17:04:15]

Description was changed from

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org
==========

to

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-04-15 17:04:16]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-15 17:05:29]

Description was changed from

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org
==========

to

==========
Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG=603369
R=oshima@chromium.org
TBR=oshima@chromium.org

Committed: https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a
Cr-Commit-Position: refs/heads/master@{#387626}
==========

[commit-bot: I haz the power, 2016-04-15 17:05:31]

Patchset 7 (id:??) landed as
https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a
Cr-Commit-Position: refs/heads/master@{#387626}