Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

Issue 1890713002: Adds WmWindow and converts WindowState to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge again Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_commands.h" 5 #include "ash/accelerators/accelerator_commands.h"
6 6
7 #include "ash/ash_switches.h" 7 #include "ash/ash_switches.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ash/wm/window_state.h" 9 #include "ash/wm/window_state.h"
10 #include "ash/wm/window_state_aura.h"
10 #include "base/command_line.h" 11 #include "base/command_line.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "build/build_config.h" 13 #include "build/build_config.h"
13 #include "chrome/browser/apps/app_browsertest_util.h" 14 #include "chrome/browser/apps/app_browsertest_util.h"
14 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/browser_commands.h" 16 #include "chrome/browser/ui/browser_commands.h"
16 #include "chrome/browser/ui/browser_finder.h" 17 #include "chrome/browser/ui/browser_finder.h"
17 #include "chrome/browser/ui/browser_window.h" 18 #include "chrome/browser/ui/browser_window.h"
18 #include "chrome/common/chrome_switches.h" 19 #include "chrome/common/chrome_switches.h"
19 #include "chrome/test/base/in_process_browser_test.h" 20 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 73
73 // When not in fullscreen, accelerators::ToggleMaximized toggles Maximized. 74 // When not in fullscreen, accelerators::ToggleMaximized toggles Maximized.
74 EXPECT_FALSE(window_state->IsMaximized()); 75 EXPECT_FALSE(window_state->IsMaximized());
75 ash::accelerators::ToggleMaximized(); 76 ash::accelerators::ToggleMaximized();
76 EXPECT_TRUE(window_state->IsMaximized()); 77 EXPECT_TRUE(window_state->IsMaximized());
77 ash::accelerators::ToggleMaximized(); 78 ash::accelerators::ToggleMaximized();
78 EXPECT_FALSE(window_state->IsMaximized()); 79 EXPECT_FALSE(window_state->IsMaximized());
79 80
80 // When in fullscreen accelerators::ToggleMaximized gets out of fullscreen. 81 // When in fullscreen accelerators::ToggleMaximized gets out of fullscreen.
81 EXPECT_FALSE(window_state->IsFullscreen()); 82 EXPECT_FALSE(window_state->IsFullscreen());
82 Browser* browser = chrome::FindBrowserWithWindow(window_state->window()); 83 Browser* browser = chrome::FindBrowserWithWindow(window_state->aura_window());
83 ASSERT_TRUE(browser); 84 ASSERT_TRUE(browser);
84 chrome::ToggleFullscreenMode(browser); 85 chrome::ToggleFullscreenMode(browser);
85 EXPECT_TRUE(window_state->IsFullscreen()); 86 EXPECT_TRUE(window_state->IsFullscreen());
86 ash::accelerators::ToggleMaximized(); 87 ash::accelerators::ToggleMaximized();
87 EXPECT_FALSE(window_state->IsFullscreen()); 88 EXPECT_FALSE(window_state->IsFullscreen());
88 EXPECT_FALSE(window_state->IsMaximized()); 89 EXPECT_FALSE(window_state->IsMaximized());
89 ash::accelerators::ToggleMaximized(); 90 ash::accelerators::ToggleMaximized();
90 EXPECT_FALSE(window_state->IsFullscreen()); 91 EXPECT_FALSE(window_state->IsFullscreen());
91 EXPECT_TRUE(window_state->IsMaximized()); 92 EXPECT_TRUE(window_state->IsMaximized());
92 } 93 }
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 146
146 ash::accelerators::ToggleFullscreen(); 147 ash::accelerators::ToggleFullscreen();
147 EXPECT_TRUE(window_state->IsFullscreen()); 148 EXPECT_TRUE(window_state->IsFullscreen());
148 EXPECT_TRUE(IsInImmersiveFullscreen(window_state)); 149 EXPECT_TRUE(IsInImmersiveFullscreen(window_state));
149 150
150 ash::accelerators::ToggleFullscreen(); 151 ash::accelerators::ToggleFullscreen();
151 EXPECT_TRUE(IsInitialShowState(window_state)); 152 EXPECT_TRUE(IsInitialShowState(window_state));
152 153
153 // 2) ToggleFullscreen() should have no effect on windows which cannot be 154 // 2) ToggleFullscreen() should have no effect on windows which cannot be
154 // maximized. 155 // maximized.
155 window_state->window()->SetProperty(aura::client::kCanMaximizeKey, false); 156 window_state->aura_window()->SetProperty(aura::client::kCanMaximizeKey,
157 false);
156 ash::accelerators::ToggleFullscreen(); 158 ash::accelerators::ToggleFullscreen();
157 EXPECT_TRUE(IsInitialShowState(window_state)); 159 EXPECT_TRUE(IsInitialShowState(window_state));
158 160
159 // 3) Hosted apps. 161 // 3) Hosted apps.
160 Browser::CreateParams browser_create_params( 162 Browser::CreateParams browser_create_params(
161 Browser::CreateParams::CreateForApp("Test", true /* trusted_source */, 163 Browser::CreateParams::CreateForApp("Test", true /* trusted_source */,
162 gfx::Rect(), browser()->profile())); 164 gfx::Rect(), browser()->profile()));
163 165
164 Browser* app_host_browser = new Browser(browser_create_params); 166 Browser* app_host_browser = new Browser(browser_create_params);
165 ASSERT_TRUE(app_host_browser->is_app()); 167 ASSERT_TRUE(app_host_browser->is_app());
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 CloseAppWindow(app_window); 326 CloseAppWindow(app_window);
325 } 327 }
326 } 328 }
327 329
328 INSTANTIATE_TEST_CASE_P(InitiallyRestored, 330 INSTANTIATE_TEST_CASE_P(InitiallyRestored,
329 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 331 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
330 Values(ui::SHOW_STATE_NORMAL)); 332 Values(ui::SHOW_STATE_NORMAL));
331 INSTANTIATE_TEST_CASE_P(InitiallyMaximized, 333 INSTANTIATE_TEST_CASE_P(InitiallyMaximized,
332 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 334 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
333 Values(ui::SHOW_STATE_MAXIMIZED)); 335 Values(ui::SHOW_STATE_MAXIMIZED));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698