Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but then break the main waterfall.

BUG=603166
Committed: https://crrev.com/121900aaaac3ee9407ad40dd05e54b6d50b859c9
Cr-Commit-Position: refs/heads/master@{#388086}

[jam, 2016-04-13 21:30:22]

Description was changed from

==========
603166

BUG=603166
==========

to

==========
Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but
then break the main waterfall.

BUG=603166
==========

[jam, 2016-04-13 21:30:22]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2016-04-15 21:12:02]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-15 21:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/40001

[commit-bot: I haz the power, 2016-04-15 21:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 21:12:43]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jam, 2016-04-15 21:13:35]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 21:14:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/40001

[brettw, 2016-04-15 21:47:03]

lgtm

[jam, 2016-04-15 22:18:19]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-15 22:18:20]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1885933002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-04-15 22:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/80001

[commit-bot: I haz the power, 2016-04-15 23:21:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 23:21:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-04-15 23:23:58]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-15 23:24:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/80001

[commit-bot: I haz the power, 2016-04-15 23:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 23:44:26]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jabdelmalek, 2016-04-16 00:25:20]

The CQ bit was checked by jabdelmalek@google.com

[jabdelmalek, 2016-04-16 00:25:20]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1885933002/#ps100001
(title: "fix")

[commit-bot: I haz the power, 2016-04-16 00:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/100001

[commit-bot: I haz the power, 2016-04-16 03:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-16 03:11:30]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jam, 2016-04-18 19:04:23]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-18 19:04:23]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1885933002/#ps140001
(title: "add comment with installer fix")

[commit-bot: I haz the power, 2016-04-18 19:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885933002/140001

[commit-bot: I haz the power, 2016-04-19 00:07:45]

Description was changed from

==========
Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but
then break the main waterfall.

BUG=603166
==========

to

==========
Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but
then break the main waterfall.

BUG=603166
==========

[commit-bot: I haz the power, 2016-04-19 00:07:47]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-19 00:08:49]

Description was changed from

==========
Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but
then break the main waterfall.

BUG=603166
==========

to

==========
Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Otherwise patches can land in the CQ which trigger DLOG(FATAL) or assert but
then break the main waterfall.

BUG=603166

Committed: https://crrev.com/121900aaaac3ee9407ad40dd05e54b6d50b859c9
Cr-Commit-Position: refs/heads/master@{#388086}
==========

[commit-bot: I haz the power, 2016-04-19 00:08:50]

Patchset 8 (id:??) landed as
https://crrev.com/121900aaaac3ee9407ad40dd05e54b6d50b859c9
Cr-Commit-Position: refs/heads/master@{#388086}