Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7206)

Unified Diff: chrome/browser/lifetime/keep_alive_registry.h

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment with installer fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/lifetime/keep_alive_registry.h
diff --git a/chrome/browser/lifetime/keep_alive_registry.h b/chrome/browser/lifetime/keep_alive_registry.h
index 57ab79670a823fe53c4913d2c488e3cb5cfc4384..332b3d65f16c4aeab5a24bbaebddf7bfe502fa78 100644
--- a/chrome/browser/lifetime/keep_alive_registry.h
+++ b/chrome/browser/lifetime/keep_alive_registry.h
@@ -40,10 +40,10 @@ class KeepAliveRegistry {
friend struct base::DefaultSingletonTraits<KeepAliveRegistry>;
// Friend to be able to use Register/Unregister
friend class ScopedKeepAlive;
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
friend std::ostream& operator<<(std::ostream& out,
const KeepAliveRegistry& registry);
-#endif // NDEBUG
+#endif
KeepAliveRegistry();
~KeepAliveRegistry();
@@ -71,8 +71,8 @@ class KeepAliveRegistry {
DISALLOW_COPY_AND_ASSIGN(KeepAliveRegistry);
};
-#ifndef NDEBUG
+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
std::ostream& operator<<(std::ostream& out, const KeepAliveRegistry& registry);
-#endif // ndef NDEBUG
+#endif
#endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_REGISTRY_H_
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | chrome/browser/lifetime/keep_alive_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698