third_party/zlib/google/zip_reader.cc - Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment with installer fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/zlib/google/zip_reader.cc

diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc

index 91d2ec329dea2fbe01a60e8d1d370dc0be5e836a..6be6dc1e64ca48183e5e98c0c207a47f5227f7a1 100644

--- a/third_party/zlib/google/zip_reader.cc

+++ b/third_party/zlib/google/zip_reader.cc

@@ -517,7 +517,7 @@ FileWriterDelegate::FileWriterDelegate(base::File* file)

}

FileWriterDelegate::~FileWriterDelegate() {

-#if !defined(NDEBUG)

+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

const bool success =

#endif

file_->SetLength(file_length_);

« no previous file with comments | « ppapi/utility/completion_callback_factory_thread_traits.h ('k') | no next file » | no next file with comments »