base/threading/platform_thread_win.cc - Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/platform_thread_win.cc

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment with installer fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/platform_thread_win.cc

diff --git a/base/threading/platform_thread_win.cc b/base/threading/platform_thread_win.cc

index d5bd9bed08e7978714d989c2a3afcf4a135bed69..eae236634d1d9f98618d53508af11208ad0b6781 100644

--- a/base/threading/platform_thread_win.cc

+++ b/base/threading/platform_thread_win.cc

@@ -251,7 +251,7 @@ void PlatformThread::SetCurrentThreadPriority(ThreadPriority priority) {

}

DCHECK_NE(desired_priority, THREAD_PRIORITY_ERROR_RETURN);

-#ifndef NDEBUG

+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

const BOOL success =

#endif

::SetThreadPriority(PlatformThread::CurrentHandle().platform_handle(),

« no previous file with comments | « base/metrics/persistent_histogram_allocator.cc ('k') | chrome/browser/lifetime/keep_alive_registry.h » ('j') | no next file with comments »